HUE-9291 [editor] Don't error for sync results

Review Request #15111 — Created May 4, 2020 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit cb9f2e58113cddab7c1dbc5794980fe037559994
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Mon May 4 12:10:18 2020 +0200

    HUE-9291 [editor] Don't error for sync results

:100644 100644 2bd85a8936 cfc44fc313 M	desktop/core/src/desktop/js/apps/notebook2/execution/executionResult.js
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. 
      
  2. Later, one way would be also to define: if sync/async/live and then allow fetch rows if status is available or running. Can always be cleaned-up when the execution/fetch loop logic is updated with live queries (which have a running status while having result available)

  3. 
      
romain
  1. Note: it displays the result from sync, but now it tries to fetchesRows, might be better to avoid asking for fetch rows in case to sync results. Can also revamp it when doing live query option cf. above comment

    executionResult.js?1dcf:154 Uncaught (in promise) TypeError: Cannot read property 'data' of undefined
    at ExecutionResult.handleResultResponse (executionResult.js?1dcf:154)
    at ExecutionResult.fetchRows$ (executionResult.js?1dcf:149)
    at tryCatch (runtime.js?96cf:45)
    at Generator.invoke [as _invoke] (runtime.js?96cf:271)
    at Generator.prototype.<computed> [as next] (runtime.js?96cf:97)
    at tryCatch (runtime.js?96cf:45)
    at invoke (runtime.js?96cf:135)
    at eval (runtime.js?96cf:145)

  2. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...