HUE-8758 [connector] Switch from sourceType to connector only in the data catalog and entries

Review Request #15126 — Created May 7, 2020 and submitted

johan
hue
master
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 87dfae84278fea0220cdb1e95fd28714d759c8c8
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu May 7 15:34:31 2020 +0200

    HUE-8758 [connector] Switch from sourceType to connector only in the data catalog and entries

:100644 100644 fa467b632b 54887260a2 M	apps/metastore/src/metastore/templates/metastore.mako
:100644 100644 d09357a5fa 36222c3c5a M	apps/pig/src/pig/templates/app.mako
:100644 100644 051479bb90 92ece7800a M	desktop/core/src/desktop/js/apps/notebook/snippet.js
:100644 100644 d34bae2a69 75e3cee393 M	desktop/core/src/desktop/js/apps/table_browser/app.js
:100644 100644 31eda05305 03834ab3fa M	desktop/core/src/desktop/js/apps/table_browser/metastoreNamespace.js
:100644 100644 172e7a4bdb 7b396cdcb8 M	desktop/core/src/desktop/js/apps/table_browser/metastoreSource.js
:100644 100644 032df6ae1e 3da321c56d M	desktop/core/src/desktop/js/apps/table_browser/metastoreTable.js
:100644 100644 5ff528ce19 c7bd80911c M	desktop/core/src/desktop/js/catalog/catalogUtils.js
:100644 100644 4d9af85911 167065a55e M	desktop/core/src/desktop/js/catalog/dataCatalog.js
:100644 100644 63fb6f22ec 3ce82d993e M	desktop/core/src/desktop/js/catalog/dataCatalogEntry.js
:100644 100644 04fd3d9162 613608607a M	desktop/core/src/desktop/js/catalog/multiTableEntry.js
:100644 100644 3db505e28e 91cb67d5ba M	desktop/core/src/desktop/js/catalog/optimizer/localStrategy.js
:100644 100644 26cf25f060 e4e51af955 M	desktop/core/src/desktop/js/jquery/plugins/jquery.hiveautocomplete.js
:100644 100644 bd0f180a8a 8212032bd5 M	desktop/core/src/desktop/js/ko/bindings/ace/aceLocationHandler.js
:100644 100644 3423789235 a613d981e0 M	desktop/core/src/desktop/js/ko/components/assist/assistDbEntry.js
:100644 100644 d1bcc95f90 021190a18a M	desktop/core/src/desktop/js/ko/components/assist/assistDbNamespace.js
:100644 100644 9959f68a96 15867069e4 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistDashboardPanel.js
:100644 100644 f3f012f51f 6161716559 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistDbPanel.js
:100644 100644 52e42c48dc 87d42f4722 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistEditorContextPanel.js
:100644 100644 0dd81b52b5 297bcf4fa1 M	desktop/core/src/desktop/js/ko/components/contextPopover/asteriskContextTabs.js
:100644 100644 22822f376d de9bd2cfa9 M	desktop/core/src/desktop/js/ko/components/contextPopover/dataCatalogContext.js
:100644 100644 a055f91fc6 e03b34f3a1 M	desktop/core/src/desktop/js/ko/components/contextPopover/ko.contextPopover.js
:100644 100644 3656debcc5 a0512f72d4 M	desktop/core/src/desktop/js/ko/components/ko.catalogEntriesList.js
:100644 100644 26024b0445 eac1223a9f M	desktop/core/src/desktop/js/ko/components/ko.catalogEntriesList.test.js
:100644 100644 e17a621e1e 2f6e0840e3 M	desktop/core/src/desktop/js/ko/components/ko.contextSelector.js
:100644 100644 a36c01e4fd d44ddc67bb M	desktop/core/src/desktop/js/ko/components/ko.fieldSamples.js
:100644 100644 f18c37bf2f 6d08ace099 M	desktop/core/src/desktop/js/ko/components/ko.fieldSamples.test.js
:100644 100644 d676aab829 6bc313afc0 M	desktop/core/src/desktop/js/ko/components/ko.historyPanel.js
:100644 100644 5ffabdb8fc 22b0f9893a M	desktop/core/src/desktop/js/ko/components/ko.navProperties.test.js
:100644 100644 1513003862 93909343ce M	desktop/core/src/desktop/js/ko/components/ko.navTags.test.js
:100644 100644 f82632ac85 ea3bab25f9 M	desktop/core/src/desktop/js/ko/components/ko.pollingCatalogEntriesList.js
:100644 100644 a436d842ee 2ee5806f19 M	desktop/core/src/desktop/js/sql/autocompleteResults.js
:100644 100644 75d9739ff4 47e8f85e5f M	desktop/core/src/desktop/js/sql/autocompleteResults.test.js
:100644 100644 8ee9601802 a4b7686fce M	desktop/core/src/desktop/js/sql/sqlUtils.js
:100644 100644 200fce7e43 4a7f33a827 M	desktop/core/src/desktop/static/desktop/js/jquery.hiveautocomplete.js
:100644 100644 873c99a14e 30d91f3e06 M	desktop/libs/indexer/src/indexer/templates/importer.mako
:100644 100644 9159ba697c 986c023091 M	desktop/libs/notebook/src/notebook/templates/editor_components.mako
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. 
      
  2. Connector type is the same as connector dialect?

    dialect is a good name (even if not sure if object or dialect name sometimes)

    If type is more the connector Id, maybe we could change in UI + API?

    <pre>
    interpreters: [{name: "MySql", type: "9", displayName: "MySql", buttonName: "Query", tooltip: "9 Query",…},…]
    0: {name: "MySql", type: "9", displayName: "MySql", buttonName: "Query", tooltip: "9 Query",…}
    buttonName: "Query"
    dialect: "mysql"
    dialect_properties: {is_sql: true, sql_identifier_quote: "`", sql_identifier_comment_single: "--", has_catalog: true,…}
    displayName: "MySql"
    is_batchable: true
    is_sql: true
    name: "MySql"
    optimizer: "local"
    page: "/editor/?type=9"
    tooltip: "9 Query"
    type: "9"
    </pre>

    1. This is an exception for solr (the indexes panel), haven't switched that one over to use the config api yet...

      connector type is only == dialect with enable_connectors=false.

    2. +1

  3. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...