HUE-8768 [editor] Initial handling of runtime query errors

Review Request #15140 — Created May 8, 2020 and submitted

romain
hue
master
HUE-8768
hue
johan, ranade, romain, weixia, yingc
commit c88efd75bb60a5183cdee6571d73ac4df57ab8ad
Author: Romain <romain.rigaux@gmail.com>
Date:   Fri May 8 11:31:33 2020 -0700

    HUE-8768 [editor] Initial handling of runtime query errors
    
    e.g.
    
    - query fails when executing and not at submission (UDF...)
    - task server won't bubble-up error in execute()

:100644 100644 846fc96ce6 6af5c44372 M	desktop/core/src/desktop/js/api/apiHelper.js
:100644 100644 09da80d805 6c826c5e3d M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js

This one is probably not the cleanest for the long term and can wait to be pushed until we confirm. But it is a good start point to explain the issue.

"Bit" similar to the live queries returning data in check status.

// TODO: Inline instead of popup, e.g. ERROR_REGEX in Execute() as iffy without

  • 2
  • 0
  • 0
  • 0
  • 2
Description From Last Updated
import $ from 'jquery' johan johan
Red gutter marking and message in the logs? I can fix... johan johan
romain
johan
  1. Ship It!
  2. Red gutter marking and message in the logs? I can fix...

    1. Yes, we handle it properly in the execute() call (grep 'ERROR_REGEX' to find easily), but not in the check_status() (where error with same format can show-up at runtime). If the error display could be factorized and use in both calls (like in v1) that would be clean and nice UX! (as red popup is a pain)

  3. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...