HUE-9351 [editor] Only check status for new entries when refreshing the history panel in editor v2

Review Request #15149 — Created May 14, 2020 and discarded

johan
hue
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 49123e4b0961bc9acefc68bb1d428e54a04767a5
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu May 14 13:53:31 2020 +0200

    HUE-9351 [editor] Only check status for new entries when refreshing the history panel in editor v2

:100644 100644 89c3af2c6f 130df8448e M	desktop/core/src/desktop/js/apps/notebook2/components/ko.queryHistory.js
Manual on Chrome
romain
  1. The logic before was: when opening the editor the first time, fetch the history. For each query, if the status is still running or available, check its status and then update it. So over time it stays in sync and in practice there are not many running queries.

    If the problem here that we were refreshing the history a lot for some reason hence re-triggering all these checks?

    +1 for this fix or even simpler would be to avoid refetching the history that much (before it was injecting a new row for each executed query and when loading up a query/saved history of the same dialect there was no clearing of the history)
    (Does it handle the loading of a saved/history query without retriggering all the checks?)

    Can explain in person if simpler!

    1. I think indeed cleaner to skip the re-fetch and just inject, I'll fix.

      Indeed too much re-triggering, especially when all are "available" it slows it down quite a bit.

  2. 
      
johan
Review request changed

Status: Discarded

Loading...