Fish Trophy

johan got a fish trophy!

HUE-9291 [editor] Introduce 'streaming' execution status in the UI

Review Request #15151 — Created May 14, 2020 and submitted

johan
hue
hue
jgauthier, ranade, romain, roohi, weixia, yingc
commit 011dc321d8f8bd64a217ead36a729e22b95286d3
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu May 14 14:46:41 2020 +0200

    HUE-9291 [editor] Introduce 'streaming' execution status in the UI

:100644 100644 6db3e9d4e8 2e9138fde3 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableActions.js
:100644 100644 0580f6f0ee 0d522ad3e8 M	desktop/core/src/desktop/js/apps/notebook2/components/ko.executableProgressBar.js
:100644 100644 130df8448e e3d185e5ca M	desktop/core/src/desktop/js/apps/notebook2/components/ko.queryHistory.js
:100644 100644 6b1cc5492c e3456a7866 M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.js
:100644 100644 131d44aa9f db01ad07e9 M	desktop/core/src/desktop/js/apps/notebook2/execution/executionLogs.js
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. 
      
  2. Should not need to have WS one to work normally?
    Do you mean:

    if (!window.WEB_SOCKETS_ENABLED) {
    ?

    e.g. Flink has new data that we ship via the checkStatus, that way it works even without WS.

    Also Flink connector does not handle WS yet so there would be no way to get the result data. So probably better to ignore WS until the streaming results is working, then add proper WS logic.

    (which would be something like Is WS enabled globally + connector dialect supports WS + also the query might or not beed a streaming one, so this could be an attribute in the submit query handle)

    1. This review should probably have been combined with https://review.cloudera.org/r/15152/ (see executable.js) which adds an else condition that creates/appends to the result directly. Later I'll cut over the sockets to use the exact same logic, except for the api call that is.

  3. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...