HUE-9355 [core] Restrict Hue access based on DWX Virtual Warehouse groups

Review Request #15169 — Created May 19, 2020 and updated

ranade
hue
ranade-master
hue
johan, ranade, romain, subrata, yingc
commit 496a9546965b3c297ad6f8509fdedd653c8c6430
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Tue May 19 18:08:46 2020 -0700

    HUE-9355 [core] Restrict Hue access based on DWX Virtual Warehouse groups

:100644 100644 67b83cb7d3 22f04a46cd M	desktop/conf.dist/hue.ini
:100644 100644 261ad74825 e0159c9380 M	desktop/conf/pseudo-distributed.ini.tmpl
:100644 100644 579462f09b f5dcefd35f M	desktop/core/src/desktop/auth/views.py
:100644 100644 147118cdb2 8b0658881f M	desktop/core/src/desktop/conf.py
:100644 100644 8bcd5a743d 35bd7c9420 M	desktop/core/src/desktop/views.py
:100644 100644 356c194054 82894ddd96 M	desktop/libs/libsaml/src/libsaml/backend.py


  • 3
  • 0
  • 0
  • 0
  • 3
Description From Last Updated
Would you need help for adding some unit tests? romain romain
Shouldn't we logout the user too? i.e. Can he access another page of Hue directly like ../hue/editor ? (we could ... romain romain
I'll make sure 403 is renderable instead, the boohoo is specific to js incompatibility and will be misleading in this ... johan johan
romain
  1. Nice! Need to look deeper tonight/tomorrow morning but some quick comments

  2. desktop/core/src/desktop/auth/views.py (Diff revision 1)
     
     

    Would you need help for adding some unit tests?

  3. desktop/core/src/desktop/auth/views.py (Diff revision 1)
     
     

    Shouldn't we logout the user too?

    i.e. Can he access another page of Hue directly like

    ../hue/editor
    ?

    (we could also add a test for that)

  4. 
      
johan
  1. 
      
  2. desktop/core/src/desktop/views.py (Diff revision 1)
     
     

    I'll make sure 403 is renderable instead, the boohoo is specific to js incompatibility and will be misleading in this case.

  3. 
      
Loading...