HUE-9358 [hive] resetting the connection if HS2 failsover

Review Request #15185 — Created May 22, 2020 and updated

quadoss
hue
master
HUE-9358
hue
johan, ranade, romain, weixia, yingc
commit 9fe9e7627251f2f9a1d8214ac3d6ed7dd93ce873
Author: Mahesh Balakrishnan <mbalakrishnan@cloudera.com>
Date:   Fri May 22 15:25:07 2020 -0700

    HUE-9358 [hive] resetting the connection if HS2 failsover

:100644 100644 0ebfac1fc3 8e97dce748 M	apps/beeswax/src/beeswax/server/dbms.py
:100644 100644 28885bf037 08bc6c4595 M	desktop/libs/notebook/src/notebook/connectors/hiveserver2.py

Tested this manually and extensively on the cloud cluster

  • 3
  • 0
  • 0
  • 0
  • 3
Description From Last Updated
This one sounds wrong as we basically resetting the HA all the time? romain romain
This would also clears out the current sessions of eveybody at each API call romain romain
Should have no impact on 'activeEndpoint'. To note that original upsteam solution requires a different interpreter for LLAP: [notebook] [[interpreters]] ... romain romain
quadoss
Review request changed

Change Summary:

Changes made based on chat with Romain and my testing on the cloud env.

Testing Done:

  +

Tested this manually and extensively on the cloud cluster

romain
  1. 
      
  2. apps/beeswax/src/beeswax/server/dbms.py (Diff revision 1)
     
     

    This one sounds wrong as we basically resetting the HA all the time?

    1. My initial assumption was that it was not needed, but unless I add that in place, the switch over does not occur. With this it works all the time atleast we can get past the issue.

    2. Ok, will look why (as this means we would call Zookeeper for every Thrift call)

  3. 
      
romain
  1. 
      
  2. apps/beeswax/src/beeswax/server/dbms.py (Diff revision 1)
     
     

    This would also clears out the current sessions of eveybody at each API call

  3. 
      
romain
  1. 
      
  2. apps/beeswax/src/beeswax/server/dbms.py (Diff revision 1)
     
     

    Should have no impact on 'activeEndpoint'.

    To note that original upsteam solution requires a different interpreter for LLAP:

    [notebook]
    
    [[interpreters]]
    
    [[[hive]]]
    name=Hive
    interface=hiveserver2
    
    [[[llap]]]
    name=LLAP
    interface=hiveserver2
    
  3. 
      
Loading...