HUE-9372 [frontend] Auto complete values for LIMIT Clause

Review Request #15222 — Created June 9, 2020 and submitted

Sreenath
hue
master
HUE-9372
hue
johan, romain
commit 6be37704694fd71fcd73c9439da2b26aa52fd2bf
Author: sreenaths <sree@apache.org>
Date:   Tue Jun 9 19:46:59 2020 +0530

    HUE-9372. [frontend] Auto complete values for LIMIT Clause (sree)

:100644 100644 43bb3f5831 9753c28670 M	Makefile
:100644 100644 7d70a7b92d ae02126efe M	desktop/core/src/desktop/js/parse/jison/sql/generic/sql_main.jison
:100644 100644 75a401a244 8b424e2c5c M	desktop/core/src/desktop/js/parse/jison/sql/hive/sql_main.jison
:100644 100644 26c4db111d acc8f4256b M	desktop/core/src/desktop/js/parse/jison/sql/impala/sql_main.jison
:100644 100644 c748028936 c0bc82cbfe M	desktop/core/src/desktop/js/parse/sql/generic/genericAutocompleteParser.js
:100644 100644 aa90848c92 de669912d9 M	desktop/core/src/desktop/js/parse/sql/generic/genericSyntaxParser.js
:100644 100644 925f078a4f b3203ec6f7 M	desktop/core/src/desktop/js/parse/sql/generic/test/genericAutocompleteParser.Select.test.js
:100644 100644 54db227593 a92b5114dd M	desktop/core/src/desktop/js/parse/sql/hive/hiveAutocompleteParser.js
:100644 100644 da2e20fb85 2d27615481 M	desktop/core/src/desktop/js/parse/sql/hive/hiveSyntaxParser.js
:100644 100644 4d730ce0db 5448a5afbb M	desktop/core/src/desktop/js/parse/sql/hive/test/hiveAutocompleteParser.Select.test.js
:100644 100644 033b69a344 26ee861cb1 M	desktop/core/src/desktop/js/parse/sql/impala/impalaAutocompleteParser.js
:100644 100644 14d2aecd05 3ffd8efed5 M	desktop/core/src/desktop/js/parse/sql/impala/impalaSyntaxParser.js
:100644 100644 e9a35d99c3 cc2a6d3acb M	desktop/core/src/desktop/js/parse/sql/impala/test/impalaAutocompleteParser.Select.test.js

Manual & UTs

  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Sreenath
Sreenath
romain
  1. Nice!

  2. Maybe bit bigger range? e.g.

    10
    100
    1000
    5000
    10000

    ?

    Nit: just 'weight: 1' would work too?

  3. 
      
johan
  1. Super nice!

  2. weight is there to add it above UDFs (for Impala)

  3. 
      
Sreenath
johan
  1. Ship It!
  2. 
      
romain
Sreenath
  1. Ship It!
  2. 
      
Sreenath
Sreenath
Review request changed

Status: Closed (submitted)

Loading...