HUE-7738 [editor] Describe functions if needed when opened in the UDF assist panel

Review Request #15242 — Created June 17, 2020 and submitted

johan
hue
master
hue
ranade, romain, Sreenath, yingc
commit 6ed9160dd5daba9894693bf6c1ffd48a965d2033
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Jun 17 16:49:39 2020 +0200

    HUE-7738 [editor] Describe functions if needed when opened in the UDF assist panel

:100644 100644 05ed90bf00 be8d1ef8e4 M	desktop/core/src/desktop/js/ko/components/assist/ko.assistFunctionsPanel.js

commit 32d8ff1916b15a276cef76450d8c07a6126e2912
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Jun 17 16:48:51 2020 +0200

    HUE-7738 [editor] Add pub sub events for describing individual UDFs

:100644 100644 b4bc41bb5b 34e0401342 M	desktop/core/src/desktop/js/sql/reference/apiUtils.ts
:100644 100644 d80ed1d19c 2afedbd341 M	desktop/core/src/desktop/js/sql/reference/sqlReferenceRepository.ts
:100644 100644 a9f339382c 3e47f52bce M	desktop/core/src/desktop/js/sql/reference/types.ts

commit 714b3b4160c5065dca6d5a9fd75b3309ce20f9fa
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Jun 17 16:46:20 2020 +0200

    HUE-7738 [editor] Add 'beeswax' to supported describe udf dialects

:100644 100644 c4f80f5767 99bec77cdc M	apps/beeswax/src/beeswax/api.py

commit 88d88590a7163c4c0371512060fcd164d717e413
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Jun 17 16:45:32 2020 +0200

    HUE-7738 [assist] Fix cache issue in the assist udf reference panel

:100644 100644 66982f3254 d80ed1d19c M	desktop/core/src/desktop/js/sql/reference/sqlReferenceRepository.ts

commit ba2417fb8935dcb79ef66e2d1053786df388bb89
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Jun 17 09:18:15 2020 +0200

    HUE-7738 [editor] Cache the UDF categories instead of the API response to support individual describe
    
    This also moves the reminding UDF ref js to ts and takes care of some bugs found in the process.

:000000 100644 0000000000 de34cdd30b A	desktop/core/src/desktop/js/sql/reference/apiCache.ts
:100644 100644 2df4ef953d 4d07941727 M	desktop/core/src/desktop/js/sql/reference/apiUtils.test.ts
:100644 100644 7cb3bc849d b4bc41bb5b M	desktop/core/src/desktop/js/sql/reference/apiUtils.ts
:100644 100644 f72dd91c6a f43d3d2839 R098	desktop/core/src/desktop/js/sql/reference/generic/typeConversion.js	desktop/core/src/desktop/js/sql/reference/generic/typeConversion.ts
:100644 100644 5fba299358 504656202e R088	desktop/core/src/desktop/js/sql/reference/generic/udfReference.js	desktop/core/src/desktop/js/sql/reference/generic/udfReference.ts
:100644 100644 b5c83acbf1 387c191185 R098	desktop/core/src/desktop/js/sql/reference/hive/typeConversion.js	desktop/core/src/desktop/js/sql/reference/hive/typeConversion.ts
:100644 100644 35683ae5c9 f75bf128eb R093	desktop/core/src/desktop/js/sql/reference/hive/udfReference.js	desktop/core/src/desktop/js/sql/reference/hive/udfReference.ts
:100644 100644 5da73adb7b f84625502b R099	desktop/core/src/desktop/js/sql/reference/impala/setReference.js	desktop/core/src/desktop/js/sql/reference/impala/setReference.ts
:100644 100644 f72dd91c6a f43d3d2839 R098	desktop/core/src/desktop/js/sql/reference/impala/typeConversion.js	desktop/core/src/desktop/js/sql/reference/impala/typeConversion.ts
:100644 100644 8536d84841 7fc740457c R093	desktop/core/src/desktop/js/sql/reference/impala/udfReference.js	desktop/core/src/desktop/js/sql/reference/impala/udfReference.ts
:100644 000000 ab244a63dc 0000000000 D	desktop/core/src/desktop/js/sql/reference/pig/udfReference.js
:000000 100644 0000000000 7e2ebff251 A	desktop/core/src/desktop/js/sql/reference/pig/udfReference.ts
:100644 100644 ae024a6bc4 39c0e1cdb9 M	desktop/core/src/desktop/js/sql/reference/sqlReferenceRepository.test.ts
:100644 100644 535ea9c00a 66982f3254 M	desktop/core/src/desktop/js/sql/reference/sqlReferenceRepository.ts
:100644 100644 71498d01ee c6d3c90509 M	desktop/core/src/desktop/js/sql/reference/typeUtils.ts
:000000 100644 0000000000 a9f339382c A	desktop/core/src/desktop/js/sql/reference/types.ts
:100644 100644 526917e209 689f2850d2 R056	desktop/core/src/desktop/js/sql/reference/apiCache.js	desktop/core/src/desktop/js/types.ts
Manual on Chrome
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
romain
  1. 
      
  2. apps/beeswax/src/beeswax/api.py (Diff revision 1)
     
     

    This one is wrong for sure ('beeswax' is not part of any dialect).

    How did you repro the issue? (I can fix)

    1. Editor v1 without connectors.

    2. Could quick try this instead (or just push and I try)
      https://github.com/cloudera/hue/blob/master/desktop/libs/notebook/src/notebook/connectors/base.py#L395

      snippet['dialect'] = 'hive' if snippet['type'] == 'beeswax' else snippet['type']

    3. It's pushed, feel free to adjust when adding support for more dialects...

  3. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...