HUE-9379 [ui] Add absolute path in file detection to ci checks

Review Request #15249 — Created June 18, 2020 and submitted

johan
hue
master
hue
ranade, romain, Sreenath, yingc
commit 573a986c1ba6c72033388e246a34f19fb8852a4b
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Thu Jun 18 23:29:17 2020 +0200

    HUE-9379 [ui] Add absolute path in file detection to ci checks

:100644 100644 f7b7b6ede9 76ac197b2a M	.circleci/config.yml
:100644 100644 4ddf032b8f 46dee6cde4 M	package.json
:000000 100644 0000000000 18d3cbdb54 A	tools/detect-absolute-paths/detectAbsolutePaths.js

Manual on Chrome

Wrote this util to find absolute paths in the js files while debugging a build issue. Can easily be extended to include python files.

romain
  1. PS: we already added the util

    node_modules/.bin/removeNPMAbsolutePaths . in Makefile

    last yeat for the same problem, not working there?

    1. I tried that one earlier and it doesn't take care of the Vue issue. It's also likely that Vue will add more absolute paths elsewhere as we start using Vue more so thought the CI check would be handy.

    2. I see, and you or I can do a CI blog on this one, it is nice automation!

  2. 
      
romain
  1. ci piece not pushed?

    1. Now it is. Needed a CI rebuild...

  2. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...