HUE-9396 [core] Implement SAML groups check and redirect them to 403 page if not permitted.

Review Request #15276 — Created June 29, 2020 and submitted June 30, 2020, 2:55 p.m.

Information
Owner:	ranade
Repository:	hue
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	hue
People:	johan, ranade, romain, subrata, yingc

Description

commit 97579e15a6c23db920b7e263bca08185b878c1eb
Author: Prakash Ranade <ranade@cloudera.com>
Date:   Mon Jun 29 19:06:12 2020 -0700

    HUE-9396 [core] Implement SAML groups check and redirect them to 403 page if not permitted.
    
    Testing Done:
    - Tested on private setup

:100644 100644 579462f09b fa0342d273 M	desktop/core/src/desktop/auth/views.py
:100644 100644 afc0b5942a ebe6aed6d3 M	desktop/core/src/desktop/views.py
:100644 100644 a142108e2c 9e3079d416 M	desktop/libs/libsaml/src/libsaml/backend.py

Testing Done

Issues

0
0
1
1
All Issues: 2

Description	From	Last Updated
If this still relies on the session attribute it's cleaner to put the samlgroup_check here.	johan	June 30, 2020, 11:07 a.m.
Nit: "User %s not found in required SAML groups %s"...	johan	June 30, 2020, 11:07 a.m.

Ship it!

```
Ship It!
```

desktop/core/src/desktop/auth/views.py (Diff revision 1)

Show all issues

If this still relies on the session attribute it's cleaner to put the samlgroup_check here.

ranade June 30, 2020, 11:07 a.m.
```
It must be in dt_login.
```

desktop/core/src/desktop/views.py (Diff revision 1)
Show all issues
```
Nit: "User %s not found in required SAML groups %s"...
```
1. ranade June 30, 2020, 11:07 a.m.
  fixed.

You have a pending review.

Review Board 3.0.18

HUE-9396 [core] Implement SAML groups check and redirect them to 403 page if not permitted.

Status: Closed (submitted)