HUE-9381. [frontend] Table ERD (sree)
Review Request #15282 — Created July 1, 2020 and submitted
Information | |
---|---|
Sreenath | |
hue | |
master | |
HUE-9381 | |
85e179c... | |
Reviewers | |
hue | |
johan, romain |
commit a81a270ff2bd99eac0e19086c3f4bc82d31994e3 Author: sreenaths <sree@apache.org> Date: Thu Jul 2 00:01:25 2020 +0530 HUE-9381. [frontend] Table ERD (sree) :100644 100644 134c6ff0a2 1818e44b2f M apps/metastore/src/metastore/templates/metastore.mako :100644 100644 ecfbbfd218 9414b685b4 M desktop/conf.dist/hue.ini :100644 100644 3b08e81c9a b89afc0d23 M desktop/conf/pseudo-distributed.ini.tmpl :100644 100644 f8fbb57c69 818df6373c M desktop/core/src/desktop/conf.py :100644 100644 4f199fb7d8 dfab629e06 M desktop/core/src/desktop/js/apps/tableBrowser/app.js :100644 100644 1dfe658e47 13b20f3a8b M desktop/core/src/desktop/js/apps/tableBrowser/metastoreViewModel.js :000000 100644 0000000000 105072c203 A desktop/core/src/desktop/js/apps/tableBrowser/propsMappers.ts :000000 100644 0000000000 dae8d8a4b5 A desktop/core/src/desktop/js/components/er-diagram/er-diagram.scss :000000 100644 0000000000 367b8e1fff A desktop/core/src/desktop/js/components/er-diagram/index.vue :000000 100644 0000000000 e2b72ecb44 A desktop/core/src/desktop/js/components/er-diagram/lib/entities.ts :000000 100644 0000000000 aeb431a1e0 A desktop/core/src/desktop/js/components/er-diagram/lib/enums.ts :000000 100644 0000000000 8b2c24ed67 A desktop/core/src/desktop/js/components/er-diagram/lib/interfaces.ts :000000 100644 0000000000 2ba664c047 A desktop/core/src/desktop/js/components/er-diagram/lib/processor.ts :000000 100644 0000000000 0d83aaef06 A desktop/core/src/desktop/js/components/er-diagram/webcomp.ts :100644 100644 5cb7f224cc ba1e32b33c M desktop/core/src/desktop/js/utils/hueUtils.js :100644 100644 b615f3fb08 4cd84a91d8 M package-lock.json :100644 100644 367a345d80 6860b3b51d M package.json :100644 100644 fb17e802df bd486ad1a9 M tsconfig.json
Manually tested
Change Summary:
Clicking a table entity in the ERD will open the respective table's ERD.
Commit: |
|
||
---|---|---|---|
Diff: |
Revision 2 (+587 -24) |
-
Nice!!
-
desktop/conf/pseudo-distributed.ini.tmpl (Diff revision 2) Nit: [metastore] is the section of the table browser app, so probably cleaner to move there? [desktop] is generic and core hue
-
desktop/core/src/desktop/js/apps/tableBrowser/propsMappers.ts (Diff revision 2) Licensing to add on top of the new files?
e.g. https://github.com/cloudera/hue/blob/master/tools/sql-docs/topicLinker.js
Change Summary:
Animating Table ERD click throughs to give a better representation of whats happening in the UI.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+609 -25) |
Change Summary:
- Added license headers
- Divided the implimentation into multiple sub-components
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+876 -25) |
-
-
apps/metastore/src/metastore/templates/metastore.mako (Diff revision 4) Move to apps/metastore/src/conf.py?
-
-
Change Summary:
Addressed review comments.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 5 (+880 -25) |
Change Summary:
Rebased with master
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 6 (+880 -25) |
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+874 -25) |
Change Summary:
Fixing lint errors
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 8 (+903 -26) |