HUE-9381 [ui] Add limits and ellipsis to ERD component

Review Request #15290 — Created July 10, 2020 and submitted

Sreenath
hue
master
HUE-9381
hue
johan, romain

commit 506a21f0aeab413b5791a17c94831458ece942e7
Author: sreenaths sree@apache.org
Date: Fri Jul 10 14:42:43 2020 +0530

git commit -m HUE-9381 [ui] Add limits and ellipsis to ERD component

- Limit number of columns to 10, remaining will be grouped to one dummy column
- Links to/from grouped columns if any, must be connected to the dummy column
- Add ellipsis for very long table and column names
- Primary key and foreign key columns must be shown at the top

:100644 100644 1b8c4b767e 63f052e43b M desktop/core/src/desktop/js/apps/tableBrowser/propsMappers.ts
:100644 100644 a97c2e8742 932404622d M desktop/core/src/desktop/js/components/er-diagram/comps/table-entity.scss
:100644 100644 45a1ec9eda b32b70e091 M desktop/core/src/desktop/js/components/er-diagram/comps/table-entity.vue
:100644 100644 c95a6e4495 7c763e9d2b M desktop/core/src/desktop/js/components/er-diagram/index.vue
:100644 100644 4fc7f9a233 9bd0ab7fe2 M desktop/core/src/desktop/js/components/er-diagram/lib/entities.ts

Manual testing

romain
  1. Commit message "git commit -m "HUE-9381-2 [frontend] Table ERD (sree)" --> "HUE-9381 [ui] Add limits and elipsis to ERD component" with more substance to help other understand it?

    Any way to start adding tests (even very simple ones to get started) to the components now that is design is stabilizing?

  2. 
      
Sreenath
Sreenath
Sreenath
romain
  1. Nice!

    Any tests and better commit title?

    1. I am working in the UTs. Will submit as part of next patch as some substantial work is required there.

      I have changed the title to "Table ERD - Limit columns displayed per table, and add ellipsis to very long DB/table/column names", how can I make it better?

    2. cf. first comment: Hue jira, component, short & concise description about the unique changes (50 chars max if possible)
      
      Commit message "git commit -m "HUE-9381-2 [frontend] Table ERD (sree)" --> "HUE-9381 [ui] Add limits and elipsis to ERD component" with more substance to help other understand it?
      
      
      https://chris.beams.io/posts/git-commit/
    3. Thanks, got it. Updating the message.

  2. 
      
romain
  1. +1 for test skeletons in next commit

  2. 
      
Sreenath
Sreenath
Sreenath
Review request changed

Status: Closed (submitted)

Loading...