HUE-9410. [ui] Add unit testing base to vue components (sree)

Review Request #15292 — Created July 13, 2020 and submitted

Sreenath
hue
master
HUE-9410
hue
johan, romain
commit 7e79ab803ec283373da17443fada719984a4a664
Author: sreenaths <sree@apache.org>
Date:   Tue Jul 14 02:28:02 2020 +0530

    HUE-9410. [ui] Add unit testing base to vue components (sree)

:000000 100644 0000000000 7a372d5f88 A	desktop/core/src/desktop/js/components/er-diagram/er-diagram.test.ts
:100644 100644 7c763e9d2b 18004d8ac6 M	desktop/core/src/desktop/js/components/er-diagram/index.vue
:100644 100644 919738a8fa 7f11716131 M	jest.config.js
:100644 100644 82dc089151 7698e5d53e M	package-lock.json
:100644 100644 7a0940d51e 40c5388a88 M	package.json
  • Manually tested
  • Ran UTs and lint
romain
  1. Nice one!
    
    And I guess `npm run test` and `npm run test -- desktop/core/src/desktop/js/components/er-diagram/er-diagram.test.ts` run it?
    
    
    And looking forward to one with data :) 
          propsData: {
            entities: [],
            relations: []
          }
    1. UTs including lint check was ran.
      Thank you so much for pointing out the -- option, its much more cleaner than what I was using to run just ERD test.
      I was running with "./node_modules/.bin/jest -i desktop/core/src/desktop/js/components/er-diagram/er-diagram.test.ts"

      Will add tests with data as part of HUE-9381 :)
      This is just for POC

  2. 
      
Sreenath
Review request changed

Status: Closed (submitted)

Loading...