HUE-9381. ERD - Add option to hide DB name in table box
Review Request #15329 — Created July 28, 2020 and submitted
Information | |
---|---|
Sreenath | |
hue | |
master | |
HUE-9381 | |
Reviewers | |
hue | |
johan, romain |
commit ba043c4d53f6355767d0ad151d5a59f4c57ce7de Author: sreenaths <sree@apache.org> Date: Tue Jul 28 12:57:41 2020 +0530 HUE-9381. ERD - Add option to hide DB name in table box (sree) :100644 100644 63f052e43b 1d1ebb0a34 M desktop/core/src/desktop/js/apps/tableBrowser/propsMappers.ts :100644 100644 96e5eae9e0 a2a9fd9e13 M desktop/core/src/desktop/js/components/er-diagram/comps/table-entity.vue :100644 100644 9bd0ab7fe2 73f30e24c9 M desktop/core/src/desktop/js/components/er-diagram/lib/entities.ts
Manually tested & ran UTs
-
-
desktop/core/src/desktop/js/apps/tableBrowser/propsMappers.ts (Diff revision 1) Nit: Use const instead of functions to limit the scope. i.e. const createTable = (database ...) => { } Tip: Instead of Array<string> you can do string[]
-
desktop/core/src/desktop/js/apps/tableBrowser/propsMappers.ts (Diff revision 1) Nit: Add type defs/interfaces for keys