HUE-9381. ERD - Add className based styling for each entity (sree)

Review Request #15330 — Created July 28, 2020 and submitted

Sreenath
hue
master
HUE-9381
hue
johan, romain
commit ba9d832a9f0fad5c50552e9e88a072381e39d2e0
Author: sreenaths <sree@apache.org>
Date:   Tue Jul 28 16:04:30 2020 +0530

    HUE-9381. ERD - Add className based styling for each entity (sree)

:100644 100644 eacb5845af a523fc94ce M	desktop/core/src/desktop/js/components/er-diagram/comps/literal-entity.vue
:100644 100644 96e5eae9e0 84f78e77d0 M	desktop/core/src/desktop/js/components/er-diagram/comps/table-entity.vue
:100644 100644 9bd0ab7fe2 8351decc2a M	desktop/core/src/desktop/js/components/er-diagram/lib/entities.ts
:100644 100644 902bbf6b9e 18940fcb53 M	desktop/core/src/desktop/js/components/er-diagram/lib/interfaces.ts

Manually tested and ran UTs

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
johan
  1. Ship It!
  2. Nit: className: string = ''; then there's no need for the "entity.className || ''" check above
    1. That was my initial approach.
      But once it's published as web component users could be passing the values as plain JSON right. So I thought this approach might be better.

  3. 
      
Sreenath
Review request changed

Status: Closed (submitted)

Loading...