HUE-9409.[blog] Fix links and bad formatting in the code review blog post

Review Request #15342 — Created July 30, 2020 and submitted

ayush.goyal
hue
master
HUE-9409
hue
ayush.goyal, romain, Sreenath
commit bc52b23557a83089079a78c712edd2146c71ec45
Author: agl29 <ayushkr.goyal.eee15@itbhu.ac.in>
Date:   Thu Jul 30 16:46:46 2020 +0530

    HUE-9409 [blog] Fix links and bad formatting in the code review blog post

:100644 100644 1dc54cc8e3 866410370f M	docs/gethue/content/en/posts/2014-07-17-rbtools-example-how-do-easily-do-code-reviews-with-review-board.md


  • 12
  • 0
  • 4
  • 0
  • 16
Description From Last Updated
"Hue Team Development Process Using RBTools and Git" --> "Hue Development Process - How to do code changes and reviews ... romain romain
How about recommending to also check the Forum https://discourse.gethue.com/ and previous issues https://github.com/cloudera/hue/issues?q=is%3Aissue+ ? romain romain
Could we add a link to the file? e.g. [tools/scripts/hue-review]( https://github.com/cloudera/hue/blob/master/tools/scripts/hue-review) romain romain
"HUE-XXX. " --> "HUE-XXXX [component] " romain romain
for --> For romain romain
For any new link, we should use the non HTML way now (to be closer to markdown standard): e.g. <a ... romain romain
[tools/scripts/hue-review](https://github.com/cloudera/hue/blob/master/tools/scripts/hue-review) romain romain
One for Python 2.7 and another for Python 3.6 romain romain
"Runs usally take 10-20 min" romain romain
**Close > Submitted** romain romain
Please use [pull requests](https://github.com/cloudera/hue/pulls) syntax... romain romain
Please no new links with this format romain romain
Sreenath
  1. 
      
  2. Markdown preview tools must give an idea on how this actually looks. These two sentences would not come in two seperate lines. So it might be better to have them in the same line in the file too.

  3. This can be done using markdown lists - https://www.markdownguide.org/basic-syntax/#lists

  4. This can be done using markdown lists - https://www.markdownguide.org/basic-syntax/#lists

  5. 
      
ayush.goyal
Sreenath
  1. Ship It!
  2. 
      
romain
  1. Nice one!

    If the goal is to talk about the full development process now (and not just code review), added some more info

  2. "Hue Team Development Process Using RBTools and Git"

    -->

    "Hue Development Process - How to do code changes and reviews with Review Board and Git"

  3. How about recommending to also check the Forum https://discourse.gethue.com/ and previous issues https://github.com/cloudera/hue/issues?q=is%3Aissue+ ?

  4. Could we add a link to the file?
    
    e.g.
    
    [tools/scripts/hue-review](
    https://github.com/cloudera/hue/blob/master/tools/scripts/hue-review)
  5. "HUE-XXX. <Ticket summary>"
    
    -->
    
    "HUE-XXXX [component] <Ticket summary>"
  6. For any new link, we should use the non HTML way now (to be closer to markdown standard):

    e.g.

    <a href="https://github.com/cloudera/hue/pulls">pull requests</a>

    -->

    https://github.com/cloudera/hue/pulls

  7. 
      
ayush.goyal
romain
  1. Nice, almost!

  2. [tools/scripts/hue-review](https://github.com/cloudera/hue/blob/master/tools/scripts/hue-review)
  3. Please use [pull requests](https://github.com/cloudera/hue/pulls) syntax...
  4. 
      
ayush.goyal
romain
ayush.goyal
romain
  1. Ship It!
  2. 
      
ayush.goyal
Review request changed

Status: Closed (submitted)

Loading...