HUE-9423. [editor] Parser demo app build is failing with gethue

Review Request #15352 — Created Aug. 3, 2020 and discarded

Information
Sreenath
hue
master
HUE-9423
Reviewers
hue
johan, romain 
commit ce18744405c357be0c2af2159efa865fbf2a086d
Author: sreenaths <sree@apache.org>
Date:   Mon Aug 3 21:39:14 2020 +0530

    HUE-9423. [editor] Parser demo app build is failing with gethue (sree)

:100644 000000 c5fe47ceab 0000000000 D	tools/examples/api/hue_dep/README.md
:100644 000000 ed5797d2b4 0000000000 D	tools/examples/api/hue_dep/src/app.js
:100644 000000 5dc9768398 0000000000 D	tools/examples/api/hue_dep/webpack.config.js
:100644 100644 9aa8dc0bb1 9aa8dc0bb1 R100	tools/examples/api/hue_dep/.eslintignore	tools/examples/parsers/gethue/.eslintignore
:100644 100644 fa49873850 fa49873850 R100	tools/examples/api/hue_dep/.gitignore	tools/examples/parsers/gethue/.gitignore
:000000 100644 0000000000 af9cc4ebe3 A	tools/examples/parsers/gethue/README.md
:000000 100644 0000000000 966a90b9c1 A	tools/examples/parsers/gethue/package-lock.json
:000000 100644 0000000000 49bdb64afa A	tools/examples/parsers/gethue/package.json
:000000 100644 0000000000 c684f13915 A	tools/examples/parsers/gethue/src/app.js
:000000 100644 0000000000 e7da6b4c99 A	tools/examples/parsers/gethue/webpack.config.js
:000000 100644 0000000000 9aa8dc0bb1 A	tools/examples/parsers/hue_local/.eslintignore
:000000 100644 0000000000 fa49873850 A	tools/examples/parsers/hue_local/.gitignore
:000000 100644 0000000000 b8ecfb7bc4 A	tools/examples/parsers/hue_local/README.md
:000000 100644 0000000000 602348bf5e A	tools/examples/parsers/hue_local/package-lock.json
:100644 100644 4a10950175 16691f1f74 R093	tools/examples/api/hue_dep/package.json	tools/examples/parsers/hue_local/package.json
:000000 100644 0000000000 b7c49cd9af A	tools/examples/parsers/hue_local/src/app.js
:000000 100644 0000000000 8f4677fa15 A	tools/examples/parsers/hue_local/webpack.config.js
Ran demo app
  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Did you try this one with exclude node_modules and local? Just wondering if there isn't a config that would work ... johan johan
johan
johan 
  1. Ship It!
  2. Show all issues 
    Did you try this one with exclude node_modules and local?
    

    Just wondering if there isn't a config that would work for both local and gethue...
    1. Yes, I had tried with 'exclude node_modules', it was giving 'Unexpected token' error in typescript (typeUtils.ts) file.
      

      It was like babel-loader didnt process ts files under node_modules, hence removed the 'exclude: /node_modules/' config.
  3. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




romain




   

   





  

 



 

  


   

   

    
 
romain


    
   


  

  

  



    




  1. 
 
    
  
    
   
    What is the diff of the changes to make the npm gethue work? (sorry, not easy to spot here. If Johan's comment does not work, curious if better to document the diff instead of full duplication)
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Have creared a DOC only patch @ https://review.cloudera.org/r/15373/
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




Sreenath




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Discarded

  
 




 
Change Summary:

 
As suggested by Romain, we are going with a document only change instead of creating two seperate demo apps - https://review.cloudera.org/r/15373/





 


 










  

 









     

    

   

  

  

   
   Loading...