CDPD-15032 [metastore] Drop selected Databases errors

Review Request #15362 — Created Aug. 9, 2020 and submitted

ayush.goyal
hue
master
CDPD-15032
hue
romain
commit 183ed39bb9cb70203541dffbd24063fff33fdb65
Author: agl29 <ayushkr.goyal.eee15@itbhu.ac.in>
Date:   Mon Aug 10 11:39:25 2020 +0530

    CDPD-15032 [metastore] Drop selected Databases errors

:100644 100644 88486aa426 2736a50ad8 M	apps/metastore/src/metastore/views.py


  • 5
  • 0
  • 0
  • 0
  • 5
Description From Last Updated
Nice! Now we typically update/write a test for each change, and all the time when it is a regression. Why ... romain romain
styling, ' ' after : romain romain
Shouldn't we make sure we send the 'start_time' parameter in the UI in the ajax call? (to properly fix the ... romain romain
If we add it here, don't we need to update the drop table tests too? romain romain
Nice! Now let's just see how we could provide the values via the UI submission popup and it will be ... romain romain
romain
  1. 
      
  2. apps/metastore/src/metastore/views.py (Diff revision 1)
     
     

    Nice!

    Now we typically update/write a test for each change, and all the time when it is a regression.

    Why was this one not failing before?

    https://github.com/cloudera/hue/blob/master/apps/metastore/src/metastore/tests.py#L342

    Because missing is_embeddable?

    {u'database_selection': [db1, db2, db3]})
    -->
    {u'database_selection': [db1, db2, db3], 'is_embeddable': True})

    is_embeddable means when used by Hue 4 which is single UI https://gethue.com/hue-4-and-its-new-interface-is-out/ and replaced Hue 3, so this is very probably what we want to test now

  3. 
      
ayush.goyal
romain
  1. 
      
  2. apps/metastore/src/metastore/tests.py (Diff revision 2)
     
     

    styling, ' ' after :

  3. apps/metastore/src/metastore/views.py (Diff revision 2)
     
     

    Shouldn't we make sure we send the 'start_time' parameter in the UI in the ajax call? (to properly fix the problem, as it is a bug if it is not in the request)

  4. apps/metastore/src/metastore/views.py (Diff revision 2)
     
     

    If we add it here, don't we need to update the drop table tests too?

  5. 
      
ayush.goyal
romain
  1. 
      
  2. apps/metastore/src/metastore/views.py (Diff revision 3)
     
     

    Nice!

    Now let's just see how we could provide the values via the UI submission popup and it will be clean.

    As a workaround acutally:if we have the correct dates set up in the task popup we can ship it for now.

  3. 
      
ayush.goyal
Review request changed

Status: Closed (submitted)

Loading...