HUE-9454 [editor] Make it possible to define reserved keyword per dialect

Review Request #15401 — Created Aug. 26, 2020 and submitted

johan
hue
master
hue
Amlesh1902, ranade, romain, Sreenath, yingc
commit 762ca8dda4d6a78cef7d0a8d46cdfaa32022ab06
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Aug 26 13:37:42 2020 +0200

    HUE-9454 [editor] Make it possible to define reserved keyword per dialect

:100644 000000 2286e45f1b 0000000000 D	desktop/core/src/desktop/js/api/cancellablePromise.js
:000000 100644 0000000000 2e910c57d0 A	desktop/core/src/desktop/js/api/cancellablePromise.ts
:100644 100644 d27e9949d0 834a0939ba M	desktop/core/src/desktop/js/catalog/dataCatalog.js
:100644 100644 2b3ec8509a 2def4c31c3 M	desktop/core/src/desktop/js/catalog/optimizer/baseStrategy.js
:000000 100644 0000000000 0a719186e0 A	desktop/core/src/desktop/js/catalog/types.ts
:100644 100644 2d81d15e60 ac0960aeaf M	desktop/core/src/desktop/js/ko/bindings/ace/aceLocationHandler.js
:100644 100644 37942e2711 5b413e51c0 M	desktop/core/src/desktop/js/ko/components/assist/assistDbEntry.js
:100644 100644 2a93faf74c 7eae0790f6 M	desktop/core/src/desktop/js/ko/components/contextPopover/asteriskContextTabs.js
:100644 100644 e6e82fc37d fa6b3e63f8 M	desktop/core/src/desktop/js/ko/components/ko.editorDroppableMenu.js
:000000 100644 0000000000 eb7d5df996 A	desktop/core/src/desktop/js/parse/types.ts
:100644 100644 d205472296 b299738465 M	desktop/core/src/desktop/js/sql/autocompleteResults.js
:000000 100644 0000000000 1c021268f3 A	desktop/core/src/desktop/js/sql/reference/calcite/reservedKeywords.ts
:000000 100644 0000000000 df15a54db3 A	desktop/core/src/desktop/js/sql/reference/generic/reservedKeywords.ts
:000000 100644 0000000000 631ae8828d A	desktop/core/src/desktop/js/sql/reference/hive/reservedKeywords.ts
:000000 100644 0000000000 3ce8c8ff96 A	desktop/core/src/desktop/js/sql/reference/impala/reservedKeywords.ts
:000000 100644 0000000000 a8054610f7 A	desktop/core/src/desktop/js/sql/reference/postgresql/reservedKeywords.ts
:000000 100644 0000000000 e658f03b68 A	desktop/core/src/desktop/js/sql/reference/presto/reservedKeywords.ts
:100644 100644 f83ee56c83 4b23d17bfa M	desktop/core/src/desktop/js/sql/reference/sqlReferenceRepository.ts
:100644 000000 c0dbb6dbed 0000000000 D	desktop/core/src/desktop/js/sql/sqlUtils.js
:000000 100644 0000000000 542fa30094 A	desktop/core/src/desktop/js/sql/sqlUtils.ts
:000000 100644 0000000000 41a3570430 A	desktop/core/src/desktop/js/sql/types.ts
:100644 100644 40dd3917c7 7cfcdfc009 M	desktop/core/src/desktop/js/types/config.ts
:100644 100644 8eef99fb81 5af6f6140b M	desktop/core/src/desktop/js/types/types.ts
:100644 100644 1e05c98610 9bbf7da862 M	desktop/libs/indexer/src/indexer/templates/importer.mako

commit ee8a9657a80d23bf27f3f63e14ab0eaff2b9ecbd
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Wed Aug 26 13:03:29 2020 +0200

    HUE-9454 [editor] Refactor the autocompleter to use async/await instead of jQuery deferred
    
    This takes care of a couple of issues where deferreds would fire on subsequent autocompletions. It also makes it a lot easier to maintain and extend.

:100644 100644 220d4c1004 d205472296 M	desktop/core/src/desktop/js/sql/autocompleteResults.js
:100644 100644 0eb5868993 3a11ee6802 M	desktop/core/src/desktop/js/sql/autocompleteResults.test.js
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. Generic parser onwards!

  2. Nice!

    I see, reservedKeywords.ts per dialect possible now!

  3. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...