HUE-9456 [editor] Implement variable substitution in editor V2

Review Request #15405 — Created Aug. 28, 2020 and submitted

johan
hue
master
hue
Amlesh1902, ayush.goyal, ranade, romain, Sreenath, yingc
commit ac7cb27a13ed226fc723348bf4767f7c7137e305
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Aug 28 16:14:30 2020 +0200

    HUE-9456 [editor] Implement variable substitution in editor V2
    
    This moves all the variable logic from the snippet to a separate class and the substitution is now triggered on execute as opposed to on any change as before.

:100644 100644 9c9fe30e4f bf417e7fbb M	desktop/core/src/desktop/js/api/cancellableJqPromise.ts
:100644 100644 deb1f899aa db7ea82a77 M	desktop/core/src/desktop/js/apps/notebook2/execution/executor.ts
:100644 100644 9d16579e73 fcca85c1e5 M	desktop/core/src/desktop/js/apps/notebook2/execution/sqlExecutable.ts
:100644 100644 bfae6904b0 29c895f33d M	desktop/core/src/desktop/js/apps/notebook2/snippet.js
:000000 100644 0000000000 7fa54c1d5d A	desktop/core/src/desktop/js/apps/notebook2/variableSubstitution.ts
:100644 100644 f4c5f2033a 58f461430b M	desktop/core/src/desktop/js/parse/types.ts
:100644 100644 5af6f6140b b8124497c0 M	desktop/core/src/desktop/js/types/types.ts
:100644 100644 e91481e3c7 8707e775bf M	desktop/libs/notebook/src/notebook/templates/editor_components2.mako

commit 779501d4f8bdfdc74c98547f671d3177f8590f64
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Aug 28 06:57:30 2020 +0200

    HUE-9456 [editor] Make sure executable ID doesn't change after loading from history in editor v2

:100644 100644 ce7766495b 9d16579e73 M	desktop/core/src/desktop/js/apps/notebook2/execution/sqlExecutable.ts

commit 13815e862c64885e1701b9eaaeacb4be3a168c2f
Author: Johan Ahlen <johan@johanahlen.com>
Date:   Fri Aug 28 06:16:53 2020 +0200

    HUE-9456 [editor] Set initial handle optionals and add session verification in editor v2

:100644 100644 2ae8f495d1 226d109d7f M	desktop/core/src/desktop/js/apps/notebook2/execution/apiUtils.ts
:100644 100644 934da52ce0 5f8e4e092c M	desktop/core/src/desktop/js/apps/notebook2/execution/executable.ts
Manual on Chrome
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
romain
  1. Ship It!
  2. 
      
johan
Review request changed

Status: Closed (submitted)

Loading...