HUE-9479 [parser] Improve Hive parser to return join details

Review Request #15449 — Created Sept. 17, 2020 and discarded

Sreenath
hue
master
HUE-9479
hue
johan, romain
commit 96dea3f43b360c123a247478dfd9712e6f22ca2e
Author: sreenaths <sree@apache.org>
Date:   Fri Sep 18 01:00:52 2020 +0530

    HUE-9479 [parser] Improve Hive parser to return join details

:100644 100644 dbe398a72d 193e132101 M	desktop/core/src/desktop/js/parse/jison/sql/hive/sql_main.jison
:100644 100644 2ad8283755 f09e94afa9 M	desktop/core/src/desktop/js/parse/sql/generic/genericAutocompleteParser.js
:100644 100644 2d862ce67f 877a6cc2bb M	desktop/core/src/desktop/js/parse/sql/generic/genericSyntaxParser.js
:100644 100644 9211891185 eb1ba100c9 M	desktop/core/src/desktop/js/parse/sql/hive/hiveAutocompleteParser.js
:100644 100644 909c86231d ca59eca07f M	desktop/core/src/desktop/js/parse/sql/hive/hiveSyntaxParser.js
:100644 100644 41b08b0c24 cd8620ef37 M	desktop/core/src/desktop/js/parse/sql/impala/impalaAutocompleteParser.js
:100644 100644 9aab40e7c7 4c97baae81 M	desktop/core/src/desktop/js/parse/sql/impala/impalaSyntaxParser.js
:100644 100644 b2b156afe7 146faa6249 M	desktop/core/src/desktop/js/parse/sql/sqlParseUtils.js

Ran UTs

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
romain
  1. Any chance to add a test?

  2. 
      
johan
  1. +1 for tests in hiveAutocompleteParser.Locations.test.js

    And remove the generated Generic and Impala parsers, not sure why they have changes as their sql_main.jison files aren't updated.

    1. Added UTs
      npm run lint-fix was getting stuck, so formatting was done using ./node_modules/.bin/eslint --fix "desktop/core/src/desktop/js/parse/sql/hive/test/hiveAutocompleteParser.Locations.test.js". Still the intentation is not that great.

    2. Also thought the generic and imapal files might be changed as sqlParseUtils.js was changed, they are getting regenerated everytime I run make sql-all-parsers.

      That said removing them from current patch.

  2. 
      
johan
  1. 
      
  2. Remove, it's already in valueExpression in line above.

  3. 
      
Sreenath
Sreenath
Review request changed

Status: Discarded

Loading...