Fish Trophy

Sreenath got a fish trophy!

HUE-9479 [parser] Improve Hive parser to return join details

Review Request #15451 — Created Sept. 20, 2020 and updated

Sreenath
hue
master
HUE-9479
hue
Amlesh1902, johan, ranade, romain, yingc
commit dee794ddf96691f0a0f8d74f3f030876a417cb2e
Author: sreenaths <sree@apache.org>
Date:   Mon Sep 21 11:05:10 2020 +0530

    HUE-9479 [parser] Improve Hive parser to return join details

:100644 100644 dbe398a72d 193e132101 M	desktop/core/src/desktop/js/parse/jison/sql/hive/sql_main.jison
:100644 100644 9211891185 eb1ba100c9 M	desktop/core/src/desktop/js/parse/sql/hive/hiveAutocompleteParser.js
:100644 100644 909c86231d ca59eca07f M	desktop/core/src/desktop/js/parse/sql/hive/hiveSyntaxParser.js
:100644 100644 552b70b01b 022fbe3f22 M	desktop/core/src/desktop/js/parse/sql/hive/test/hiveAutocompleteParser.Locations.test.js
:100644 100644 b2b156afe7 63ccbfe928 M	desktop/core/src/desktop/js/parse/sql/sqlParseUtils.js

Ran UTs

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
This doesn't seem right... joinType.joinType.joinType also, the joinType attr shouldn't have 'suggestJoinConditions'. johan johan
johan
  1. 
      
  2. This doesn't seem right... joinType.joinType.joinType

    also, the joinType attr shouldn't have 'suggestJoinConditions'.

  3. 
      
romain
  1. Bump on this one!

    Also could we move it to a PR instead of review board?

    +1 for in impala dialect too
    Curious if we support the LEFT JOIN syntax also

    1. Moving topic to https://github.com/cloudera/hue/pull/1545

  2. 
      
Loading...