HUE-9381 [ui] Table ERD - Add CSS className support to IRelation

Review Request #15452 — Created Sept. 20, 2020 and updated

Sreenath
hue
master
HUE-9381
hue
johan, romain
commit 0f0c42063963aa4d82e50deb0db9d6ef710803c4
Author: sreenaths <sree@apache.org>
Date:   Mon Sep 21 12:21:20 2020 +0530

    HUE-9381 [ui] Table ERD - Add CSS className support to IRelation

:100644 100644 d101767967 e37bb6ba7a M	desktop/core/src/desktop/js/components/er-diagram/index.vue
:100644 100644 8351decc2a 8547599eb7 M	desktop/core/src/desktop/js/components/er-diagram/lib/entities.ts
:100644 100644 18940fcb53 66e3b56cb4 M	desktop/core/src/desktop/js/components/er-diagram/lib/interfaces.ts

manually tested and ran UTs

  • 6
  • 0
  • 0
  • 0
  • 6
Description From Last Updated
Do we need all these comments? (or just rename the variable similarly to `cssClass` to be explicit enough) romain romain
Drop? romain romain
Drop? romain romain
Drop? romain romain
Drop? romain romain
Drop? romain romain
Sreenath
Review request changed

Bugs:

+HUE-9381
romain
  1. 
      
  2. Do we need all these comments?
    (or just rename the variable similarly to `cssClass` to be explicit enough)

    1. That would be nice. Will make the change.

  3. 
      
romain
Loading...