- Download Diff

Summary:

HUE-9497 [query browser] Facets selection

Review Request #15509 — Created Oct. 9, 2020 and submitted Oct. 18, 2020, 9:55 p.m.

Information
Owner:	ayush.goyal
Repository:	hue
Branch:	master
Bugs:	HUE-9497
Depends On:
Reviewers
Groups:	hue
People:	Amlesh1902, johan, ranade, romain, Sreenath, yingc

Description

commit ac952660cfcbe5b63ad24e0996bfa6af5b59b39b
Author: ayush.goyal <ayush.goyal@cloudera.com>
Date:   Sat Oct 10 01:13:40 2020 +0530

    HUE-9497 [query browser] Facets selection

:100644 100644 92a0fa4d1e c48fdbc221 M	apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py

Testing Done

Issues

6
0
0
0
All Issues: 6

Description	From	Last Updated
please use Mocks instead	romain	Oct. 12, 2020, 7:21 a.m.
We should not need yet another method? If filters is empty in _get_queries, we could just use this one?	romain	Oct. 13, 2020, 8:43 p.m.
applecation -->	romain	Oct. 13, 2020, 8:43 p.m.
_get_queries	romain	Oct. 13, 2020, 8:43 p.m.
test_get_queries	romain	Oct. 13, 2020, 8:43 p.m.
nit: if we want to be consistent name wise _get_all_queries	romain	Oct. 14, 2020, 3:32 a.m.

```
Nice !
nd unit test?
```

Diff:

Revision 2 (+47 -46)

Show changes

	apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py
	apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py

Fix it!

Should be cleaner to move in dedicated method with mocks

apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py (Diff revision 2)
Show all issues
```
please use Mocks instead
```

Diff:

Revision 3 (+46 -46)

Show changes

	apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py
	apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py

Fix it!

apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py (Diff revision 3)

Show all issues

We should not need yet another method?

If filters is empty in _get_queries, we could just use this one?

ayush.goyal Oct. 13, 2020, 11:36 p.m.

Actually this method gives all the queries which are in db. So i am separating it from filtered query fuction for more explicit. And it also helping in doing testing for filtered queries.

apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py (Diff revision 3)
Show all issues
```
applecation -->
```
apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py (Diff revision 3)
Show all issues
```
_get_queries
```

apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py (Diff revision 3)

Show all issues

test_get_queries

ayush.goyal Oct. 13, 2020, 11:36 p.m.

There are 2 function _get_queries and get_queries so this test function is for _get_queries if you want i can remove it.

Diff:

Revision 4 (+40 -50)

Show changes

	apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py
	apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py

Ship it! Fix it!

apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py (Diff revision 4)
Show all issues
```
nit: if we want to be consistent name wise
_get_all_queries
```

Diff:

Revision 5 (+40 -50)

Show changes

	apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py
	apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py

Diff:

Revision 6 (+40 -50)

Show changes

	apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py
	apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py

You have a pending review.

Review Board 3.0.17

HUE-9497 [query browser] Facets selection

Diff:

Diff:

Diff:

Diff:

Diff:

Status: Closed (submitted)