HUE-9497 [query browser] Facets selection
Review Request #15509 — Created Oct. 9, 2020 and submitted
Information | |
---|---|
ayush.goyal | |
hue | |
master | |
HUE-9497 | |
Reviewers | |
hue | |
Amlesh1902, johan, ranade, romain, Sreenath, yingc |
commit ac952660cfcbe5b63ad24e0996bfa6af5b59b39b Author: ayush.goyal <ayush.goyal@cloudera.com> Date: Sat Oct 10 01:13:40 2020 +0530 HUE-9497 [query browser] Facets selection :100644 100644 92a0fa4d1e c48fdbc221 M apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py
- 6
- 0
- 0
- 0
- 6
Description | From | Last Updated |
---|---|---|
please use Mocks instead |
|
|
We should not need yet another method? If filters is empty in _get_queries, we could just use this one? |
|
|
applecation --> |
|
|
_get_queries |
|
|
test_get_queries |
|
|
nit: if we want to be consistent name wise _get_all_queries |
|
-
Should be cleaner to move in dedicated method with mocks
-
apps/jobbrowser/src/jobbrowser/apis/hive_query_api_tests.py (Diff revision 2) please use Mocks instead
-
-
apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py (Diff revision 3) We should not need yet another method? If filters is empty in _get_queries, we could just use this one?
-
-
-
-
-
apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py (Diff revision 4) nit: if we want to be consistent name wise
_get_all_queries