HUE-9497 [query browser] Facets selection

Review Request #15509 — Created Oct. 9, 2020 and submitted

ayush.goyal
hue
master
HUE-9497
hue
Amlesh1902, johan, ranade, romain, Sreenath, yingc
commit ac952660cfcbe5b63ad24e0996bfa6af5b59b39b
Author: ayush.goyal <ayush.goyal@cloudera.com>
Date:   Sat Oct 10 01:13:40 2020 +0530

    HUE-9497 [query browser] Facets selection

:100644 100644 92a0fa4d1e c48fdbc221 M	apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py


  • 6
  • 0
  • 0
  • 0
  • 6
Description From Last Updated
please use Mocks instead romain romain
We should not need yet another method? If filters is empty in _get_queries, we could just use this one? romain romain
applecation --> romain romain
_get_queries romain romain
test_get_queries romain romain
nit: if we want to be consistent name wise _get_all_queries romain romain
romain
  1. Nice !

    nd unit test?

  2. 
      
ayush.goyal
romain
  1. Should be cleaner to move in dedicated method with mocks

  2. please use Mocks instead

  3. 
      
ayush.goyal
romain
  1. 
      
  2. We should not need yet another method?
    
    If filters is empty in _get_queries, we could just use this one?
    1. Actually this method gives all the queries which are in db. So i am separating it from filtered query fuction for more explicit. And it also helping in doing testing for filtered queries.

    1. There are 2 function _get_queries and get_queries so this test function is for _get_queries if you want i can remove it.

  3. 
      
ayush.goyal
romain
  1. 
      
  2. nit: if we want to be consistent name wise

    _get_all_queries

  3. 
      
ayush.goyal
ayush.goyal
ayush.goyal
Review request changed

Status: Closed (submitted)

Loading...