HUE-9510 [querybrowser] Config flag for proxy

Review Request #15520 — Created Oct. 23, 2020 and submitted

ayush.goyal
hue
master
HUE-9510
hue
Amlesh1902, johan, ranade, romain, Sreenath, yingc
commit 190478f3c8785a6f353b82dbdc432fa9196b12f8
Author: ayush.goyal <ayush.goyal@cloudera.com>
Date:   Fri Oct 23 17:29:51 2020 +0530

    HUE-9510 [querybrowser] Config flag for proxy

:100644 100644 d94790804a 5b4c415a49 M	apps/jobbrowser/src/jobbrowser/conf.py
:100644 100644 ef5bca63ed f8f389cc37 M	apps/jobbrowser/src/jobbrowser/urls.py
:100644 100644 d685c9cc70 c6af398a30 M	desktop/conf.dist/hue.ini
:100644 100644 a732f3bf9b 6ab75ce2ea M	desktop/conf/pseudo-distributed.ini.tmpl


  • 9
  • 0
  • 0
  • 0
  • 9
Description From Last Updated
Bit more explicit? e.g. "Use the proxy API instead of the ORM to access the query_store" also --> True as ... romain romain
What is the logic there? Is the frontend going to change the URLs when not using the proxy? I thought ... romain romain
nit: space after ## romain romain
Why change it to API? Sreenath Sreenath
In a follow-up commit, we should handle the switch to the ORM based API in the else romain romain
--> query_store_download_bundle ? romain romain
Doubt if this is required? We just need to switch off the proxy not the zip download. Sreenath Sreenath
+1, for now it should be available both in v1/v2 romain romain
Guess ideally proxy kill switch would have been an extra condition here. Sreenath Sreenath
romain
  1. 
      
  2. apps/jobbrowser/src/jobbrowser/conf.py (Diff revision 1)
     
     

    Bit more explicit?

    e.g.

    "Use the proxy API instead of the ORM to access the query_store"

    also --> True as default for now

  3. apps/jobbrowser/src/jobbrowser/urls.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
    What is the logic there?
    
    Is the frontend going to change the URLs when not using the proxy?
    
    I thought that the URLs would not change but that the API would either proxy or use the ORM, so to use USE_PROXY only in https://github.com/cloudera/hue/blob/master/apps/jobbrowser/src/jobbrowser/api2.py#L171 to do the switch?
    
    e.g. and here use ORM only
    https://github.com/cloudera/hue/blob/master/apps/jobbrowser/src/jobbrowser/apis/hive_query_api.py#L100
  4. nit: space after ##
  5. 
      
ayush.goyal
Sreenath
  1. 
      
  2. apps/jobbrowser/src/jobbrowser/api2.py (Diff revision 2)
     
     

    Why change it to API?

    1. I think the idea is that when v2 is enabled, we don't really proxy anymore, so API is more generic (like we need to rename it in the UI), so makes sense IIUC

  3. apps/jobbrowser/src/jobbrowser/api2.py (Diff revision 2)
     
     

    Doubt if this is required? We just need to switch off the proxy not the zip download.

  4. apps/jobbrowser/src/jobbrowser/urls.py (Diff revision 2)
     
     

    Guess ideally proxy kill switch would have been an extra condition here.

  5. 
      
romain
  1. 
      
  2. apps/jobbrowser/src/jobbrowser/api2.py (Diff revision 2)
     
     

    In a follow-up commit, we should handle the switch to the ORM based API in the else

  3. apps/jobbrowser/src/jobbrowser/api2.py (Diff revision 2)
     
     

    --> query_store_download_bundle ?

  4. apps/jobbrowser/src/jobbrowser/api2.py (Diff revision 2)
     
     

    +1, for now it should be available both in v1/v2

  5. 
      
ayush.goyal
ayush.goyal
Review request changed

Status: Closed (submitted)

Loading...