HUE-9517 [solr] CSV file with pipe seperator or any seperator when importing

Review Request #15525 — Created Oct. 27, 2020 and submitted Oct. 28, 2020, 3:16 p.m.

Information
Owner:	quadoss
Repository:	hue
Branch:	master
Bugs:	HUE-9517
Depends On:
Reviewers
Groups:	hue
People:	asnaik, johan, ranade, romain, weixia, yingc

Description

commit 3b8aefaab7291fbabd1a6addb6d49914c1f151d5
Author: Mahesh Balakrishnan <mbalakrishnan@cloudera.com>
Date:   Tue Oct 27 15:31:54 2020 -0700

    HUE-9517 [solr] fix for CSV file with pipe seperator or any seperator when importing

:100644 100644 900e03445e dfaa814058 M	desktop/libs/indexer/src/indexer/api3.py

Testing Done

Testing this manually for a customer issue.

Issues

0
0
2
0
All Issues: 2

Description	From	Last Updated
I think lint style check will complaint fieldSeparator==',', so fieldSeparator == ',' having a space front and back of ==	yingc	Oct. 27, 2020, 4:03 p.m.
Why not just? kwargs['separator'] = source['format']['fieldSeparator']	romain	Oct. 28, 2020, 2:49 p.m.

desktop/libs/indexer/src/indexer/api3.py (Diff revision 1)

Show all issues

I think lint style check will complaint fieldSeparator==',', so fieldSeparator == ',' having a space front and back of ==

quadoss Oct. 27, 2020, 4:13 p.m.
```
done fixing the spacing issue.
```

Change Summary:

fixed the spacing issue

Diff:

Revision 2 (+2)

Show changes

desktop/libs/indexer/src/indexer/api3.py

Ship it!

```
Nice!
```
desktop/libs/indexer/src/indexer/api3.py (Diff revision 2)
Show all issues
```
Why not just?
kwargs['separator']  = source['format']['fieldSeparator']
```
1. quadoss Oct. 28, 2020, 2:49 p.m.
  fixed it.

Change Summary:

made the required changes.

Diff:

Revision 3 (+1)

Show changes

desktop/libs/indexer/src/indexer/api3.py

You have a pending review.

Review Board 3.0.18

HUE-9517 [solr] CSV file with pipe seperator or any seperator when importing

Change Summary:

Diff:

Change Summary:

Diff:

Status: Closed (submitted)