HUE-9521 [kt_renewer] fix to handle renew_lifetime if set to 0m

Review Request #15527 — Created Oct. 29, 2020 and submitted Oct. 30, 2020, 9:27 a.m.

Information
Owner:	quadoss
Repository:	hue
Branch:	master
Bugs:	HUE-9521
Depends On:
Reviewers
Groups:	hue
People:	johan, ranade, romain, weixia, yingc

Description

commit 65a89884ab286f30cb8e86cd93a6bda39cf4bafe
Author: Mahesh Balakrishnan <mbalakrishnan@cloudera.com>
Date:   Thu Oct 29 15:47:38 2020 -0700

    HUE-9521 [kt_renewer] fix to handle renew_lifetime if set to 0m

:100644 100644 86dba8b546 bfa10b4b15 M	desktop/core/src/desktop/conf.py
:100644 100644 ba25bcde64 6573ccecef M	desktop/core/src/desktop/kt_renewer.py

Testing Done

Manual testing done
1. tested with renew_lifetime to 0m with config flag set to true and false
2. tested with renew_lifetime to 30m with the flag set to true and false

Issues

0
0
2
1
All Issues: 3

Description	From	Last Updated
Add this to the two hue.inis to document it?	romain	Oct. 30, 2020, 9:23 a.m.
Is it safe to set it to True by default?	yingc	Oct. 29, 2020, 5:44 p.m.
(max_retries == 0): --> max_retries == 0:	romain	Oct. 30, 2020, 9:23 a.m.

desktop/core/src/desktop/conf.py (Diff revision 1)

Show all issues

Is it safe to set it to True by default?

quadoss Oct. 29, 2020, 5:44 p.m.

Yes, generally the renew_lifetime is a non zero param so setting it true makes the kt_renewer behave the way it currently is. Setting it to false with renew_lifetime = 0m works differently as this will do use the kinit -R command.

Ship it!

Same, we could add a unit test?
( I could do the skeleton if simpler for getting started)

desktop/core/src/desktop/conf.py (Diff revision 1)
Show all issues
```
Add this to the two hue.inis to document it?
```
desktop/core/src/desktop/kt_renewer.py (Diff revision 1)
Show all issues
```
(max_retries == 0): --> max_retries == 0:
```

Change Summary:

fixed the max_retries and included the info in ini files. I had this info in ini files but under a different path and branch.

Diff:

Revision 2 (+13 -2)

Show changes

	desktop/conf/pseudo-distributed.ini.tmpl
	desktop/conf.dist/hue.ini
	desktop/core/src/desktop/conf.py
	desktop/core/src/desktop/kt_renewer.py

You have a pending review.

Review Board 3.0.18

HUE-9521 [kt_renewer] fix to handle renew_lifetime if set to 0m

Change Summary:

Diff:

Status: Closed (submitted)