HUE-9521 [kt_renewer] fix to handle renew_lifetime if set to 0m

Review Request #15527 — Created Oct. 29, 2020 and submitted

quadoss
hue
master
HUE-9521
hue
johan, ranade, romain, weixia, yingc
commit 65a89884ab286f30cb8e86cd93a6bda39cf4bafe
Author: Mahesh Balakrishnan <mbalakrishnan@cloudera.com>
Date:   Thu Oct 29 15:47:38 2020 -0700

    HUE-9521 [kt_renewer] fix to handle renew_lifetime if set to 0m

:100644 100644 86dba8b546 bfa10b4b15 M	desktop/core/src/desktop/conf.py
:100644 100644 ba25bcde64 6573ccecef M	desktop/core/src/desktop/kt_renewer.py

Manual testing done
1. tested with renew_lifetime to 0m with config flag set to true and false
2. tested with renew_lifetime to 30m with the flag set to true and false

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
yingc
  1. 
      
  2. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Is it safe to set it to True by default?

    1. Yes, generally the renew_lifetime is a non zero param so setting it true makes the kt_renewer behave the way it currently is. Setting it to false with renew_lifetime = 0m works differently as this will do use the kinit -R command.

  3. 
      
romain
  1. Same, we could add a unit test?
    ( I could do the skeleton if simpler for getting started)

  2. desktop/core/src/desktop/conf.py (Diff revision 1)
     
     

    Add this to the two hue.inis to document it?

  3. desktop/core/src/desktop/kt_renewer.py (Diff revision 1)
     
     

    (max_retries == 0): --> max_retries == 0:

  4. 
      
quadoss
quadoss
Review request changed

Status: Closed (submitted)

Loading...