hbase-2208, a simple fix

Review Request #165 - Created June 10, 2010 and submitted

stack
old-hbase
trunk
hbase-2208
hbase
Patch that changes interface for batch put and delete so passes List instead of an array.

Straight-forward change but for some generics wrestling and some gratuitous eclipse reformatting of imports.
Tests pass but testzookeeper (something broke this).
  1. strange, I could have sworn that IPC didn't work with List<> types. But if tests pass, guess it's OK. Do we have a benchmark that shows it's beneficial?
    1. No benchmark.  Seems plain that saving a copy that could be large could only be beneficial?
  2. 
      
  1. +1, lgtm. I didn't realize that HBase's hacked version of IPC does indeed support Lists in trunk. And your point about avoiding a shallow copy makes good sense.
  2. 
      
Loading...