Change Summary:
Added code generator and tests. Still more to do.
Review Request #1760 - Created May 22, 2011 and submitted
Information | |
---|---|
Jonathan Hsieh | |
old-flume | |
flume-632 | |
Reviewers | |
flume | |
bruce.mitchener, esammer |
Using the infrastructure setup by flume-635, flume-420, and flume-299, this patch rather trivially adds subargument support for the output format builders. This patch is not complete, but will be after its dependencies are resolved. Specifically, I need to add support to other sinks that use output formats, and more functional tests.
tests on subargs branch pass tests.
Added code generator and tests. Still more to do.
flume-core/src/main/java/com/cloudera/flume/conf/FlumeSpecGen.java (Diff revision 2) |
---|
style: I think the preferred method is to not have a surrogate to determine the iteration. for (int i = 1; i < t.getChildCount(); i++) { if (i > 1) { sb.append(", "); } sb.append(genArg((CommonTree)t.getChild(i)); }
What's the difference between createOutputFormat() and getOutputFormat()? Any reason not to overload one rather than have two that (appear to) do the same thing?