Review for HBASE-2509

Review Request #18 - Created May 6, 2010 and discarded

jiratracker
old-hbase
HBASE-2509
hbase
Automatically posted review on behalf of "stack (JIRA)" <jira@apache.org>

     [ https://issues.apache.org/jira/browse/HBASE-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-2509:
-------------------------

    Attachment: hbase-2509-v3.patch

Here's Ryan's patch with a unit test. Condition is kinda hard to manufacture. I had to kinda force it by artificially setting closing flag on region and then adding new threads.... rather than do a straight close.   But I get a NPE so for sure its possible.

Committing.

> NPEs in various places, HRegion.get, HRS.close
> ----------------------------------------------
>
>                 Key: HBASE-2509
>                 URL: https://issues.apache.org/jira/browse/HBASE-2509
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.4
>            Reporter: ryan rawson
>         Attachments: HBASE-2509-v2.txt, hbase-2509-v3.patch, HBASE-2509.txt
>
>
> ttr on irc reported that he was unable to get/scan sometimes, was getting NPEs.
> The root cause is a delayed init of the RegionScanner.storeHeap means it can be null, not all accessors of it (specifically in close()) checked for that.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.




Loading...