flume-667: stacks webapps is missing from node and master / flume-668: add logs webapp to master and node.

Review Request #1828 - Created June 18, 2011 and submitted

Jonathan Hsieh
old-flume
flume-667, flume-668
flume
arvind, esammer
stacks is a webapplet that didn't make it with the maven transition but is one that is critical for debugging deadlocking problems.  Re-added

logs is a a webapplet that points to a dir and allows the files to be browsed.  This is great for log files.
started master/node in eclipse, then went to /stacks or /logs urls.

There is currently no unit tests on this functionality.  I feel that it may be possible (as well as getting the jersey related servlet in here as well).

  1. 
      
  2. 
      
Review request changed

Change Summary:

Reread description -- there is a pretty serious word omission. There are *no* unit test on this functionality currently.  I really want Sammer to see this just in case I'm missing something.

Testing Done:

   

started master/node in eclipse, then went to /stacks or /logs urls.

   
~  

There is currently unit tests on this functionality. I feel that it may be possible (as well as getting the jersey related servlet in here as well).

  ~

There is currently no unit tests on this functionality. I feel that it may be possible (as well as getting the jersey related servlet in here as well).

  1. I think this is a terrible idea. The whole reason I refactored the internal web server was to move everything to a "normal" web application environment so it was clear where things were configured and how they where used (in a standard web.xml file). Now we're back to a situation where half of the configuration is done in code and can't be modified independent of the FlumeNode itself. I'm sure we can find a better way to do this. If we keep cutting corners we're just going to have to deal with the mess later.
    
    All of that said, I'm tired of being the person no one likes. Ship it. I'll deal with it later.
    1. Eric,
      
      I understood the need for refactoring due to the externally compiled jsp files and loading the wars in a standard way.  I'm less familiar with the web.xml -- but I think what you are saying is that there is a way to do this via the xml file instead of via code.  Could you explain what the mess later will be?
      
      Jon.
      
      
  2. 
      
Loading...