Please turn it on in your browser preferences.
for specific sites, we recommend the
Review Request #1843 -
Created June 24, 2011 and submitted
Add input/output buffering to the source/sink thrift sockets
A few nits.
Did you run the tests and did they pass?
spacing nits. also, no @author tags please (your name will be in the commit log)
Don't think it's necessary. This check is really only here for the case when the TBufferedSocket is initialized using an existing Socket (which may or may not be opened), and we don't currently use this initializer.
space not tabs please.
cleanup & removed author tag
Revision 2 (+66 -3)