FLUME-688: Add %{timestamp} to escapable tags

Review Request #1848 - Created June 27, 2011 and submitted

Alex Baranau
old-flume
FLUME-688
flume
Added handling %{timestamp} tag to Event.

Note: changed "" + getNanos() to String.valueOf(getNanos()) along the way as this is more efficient.
added unit-test which covers escaping event properties (not attributes)
  1. looks good, please add docs to flume-docs/src/docs/UserGuide/UsingOutput
  2. 
      
Review request changed
  1. Nice little optimization replacing the string concats.
    
    I just noticed this from docs update - mind doing one more tweak?
  2. how is %{timestamp} different from %t?  
    
    Looking at the code it actually is a little subtle (but different).  
    
    Maybe put that in the description unix time milliseconds as a string? and update the %t to say it is in binary?
  3. 
      
  1. committing and filing follow up issue to document.
  2. 
      
Loading...