HUE-559. Shell setuid binary should be in a build directory.

Review Request #1861 - Created July 5, 2011 and updated

Aditya Acharya
old-hue
HUE-559
hue
bcwalrus
The setuid binary for the shell app should be in a build directory so that it can be properly excluded from the tarball installation.
Verified that was still able to create and control a subprocess with the binary in the new location.

I also performed the following steps:
1. Run make prod to build the production tarball
2. Extract the tarball into /tmp
3. Run "make install" to install the tarball.

I verified that after step 2, the setuid binary is not included, but it is properly created with the appropriate permissions after step 3.
Review request changed

Change Summary:

Added testing info for the production tarball

Testing Done:

   

Verified that was still able to create and control a subprocess with the binary in the new location.

  +
  +

I also performed the following steps:

  + 1. Run make prod to build the production tarball
  + 2. Extract the tarball into /tmp
  + 3. Run "make install" to install the tarball.

  +
  +

I verified that after step 2, the setuid binary is not included, but it is properly created with the appropriate permissions after step 3.

  1. 
      
  2. apps/shell/src/shell/Makefile (Diff revision 1)
     
     
    Would change this to
      $(DESTDIR)/setuid: setuid.c
              ...
    
    When possible, the target should be real (correspond to a real file).
  3. apps/shell/src/shell/Makefile (Diff revision 1)
     
     
    Would change this to:
      mkdir -p $(@D)
  4. apps/shell/src/shell/Makefile (Diff revision 1)
     
     
     
    These should stay the same.
  5. 
      
Loading...