Review Board 1.6.3

FLUME-752: Refactor HBase sinks to re-use common code/functionality

Review Request #1900 - updated 2 years, 8 months ago

Alex Baranau Reviewers
flume
FLUME-752
None flume
As agreed in comments at https://review.cloudera.org/r/1847/ this is the part of patch dedicated solely to refactoring of HBase sinks.

New base AbstractHBaseSink was extracted which holds common functionality (common sink attributes which are basically HBase client attributes and HTable connection management code: open, close, etc.)

 
Ship it!
Posted 2 years, 8 months ago (August 25th, 2011, 3:14 a.m.)
Alex, looks good.  Please update the license and post patch to the jira.  I'll commit then (no need for another review).
change to apache license:

/**
 * Copyright 2011 The Apache Software Foundation
 *
 * Licensed to the Apache Software Foundation (ASF) under one
 * or more contributor license agreements.  See the NOTICE file
 * distributed with this work for additional information
 * regarding copyright ownership.  The ASF licenses this file
 * to you under the Apache License, Version 2.0 (the
 * "License"); you may not use this file except in compliance
 * with the License.  You may obtain a copy of the License at
 *
 *     http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */