HUE-676. [beeswax] BeeswaxServer OOME when hive loglevel set to DEBUG

Review Request #2010 - Created April 11, 2012 and submitted

bc Wong
old-hue-rw
hue-676
hue
harsh, philip, romain
commit 869f9c50f07cadce8c691c081a9e4ea2be83e101
Author: bc Wong <bcwalrus@cloudera.com>
Date:   Wed Apr 11 21:49:55 2012 -0700

    HUE-676. [beeswax] BeeswaxServer OOME when hive loglevel set to DEBUG
    
    The size is determined from the property "beeswax.log.context.size",
    which can be set in beeswax_server.sh in HADOOP_OPTS. The default is 1MB.

:000000 100644 0000000... f84282d... A	apps/beeswax/java/src/main/java/com/cloudera/beeswax/LinkedStringBuffer.java
:100644 100644 1292a5b... f2af8db... M	apps/beeswax/java/src/main/java/com/cloudera/beeswax/LogContext.java
:000000 100644 0000000... a78c700... A	apps/beeswax/java/src/test/java/com/cloudera/beeswax/LinkedStringBufferTest.java
Manual.
  • 0
  • 0
  • 4
  • 1
  • 5
Description From Last Updated
  1. Looks great!
  2. capacity == number of characters?
  3. MB is a little bit misleading (as the size of a char in Java is 2 bytes) ?
  4. Also reset the size attribute too?
    1. Ah, right. Good catch. size() was never used in the actual production code.
  5. 
      
  1. Ship It!
  2. 
      
  1. 
      
  2. why bother having this?
  3. System.getInteger() works with some type conversion, btw.
    1. I don't see a getInteger().
    2. Integer.getInteger().  I only know about it because someone used it in a different code base.  Handy, none the less.
  4. Not your bug, but using String() on bytes without a charset is generally bad.  I wonder if this can be blown up by sending it some illegal unicode.
  5. 
      
Review request changed

Status: Closed (submitted)

Loading...