Testing Done: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+73 -3) |
HUE-701 [jb] Job browser should not show the jobs from other users
Review Request #2042 — Created April 23, 2012 and submitted
Information | |
---|---|
romain | |
old-hue-rw | |
HUE-701 | |
Reviewers | |
hue | |
bcwalrus |
commit 2544f91e2f2141ce4bf215c04206ba6f1411d2bd Author: Romain Rigaux <romain@cloudera.com> Date: Mon Apr 23 17:48:54 2012 -0700 HUE-701 [jb] Job browser should not show the jobs from other users :000000 100644 0000000... 66409c5... A apps/jobbrowser/src/jobbrowser/conf.py :100644 100644 0995185... 9d9ad12... M apps/jobbrowser/src/jobbrowser/tests.py :100644 100644 e6b2aa6... 44879b1... M apps/jobbrowser/src/jobbrowser/views.py :100644 100644 ce6edd7... f275c96... M desktop/conf/pseudo-distributed.ini.tmpl
hadoop tests are also disabled manual testing
-
-
-
apps/jobbrowser/src/jobbrowser/views.py (Diff revision 1) The name is not entirely correct. It's owner or admin. Also, it's not required if the sharing is enabled. Perhaps call this "check_job_permission"?
-
apps/jobbrowser/src/jobbrowser/views.py (Diff revision 1) """Ensure that the user has access to the job. Assumes that the wrapped function takes a `jobid' param."""
-
-
apps/jobbrowser/src/jobbrowser/views.py (Diff revision 1) Nit: " the job: %s" -> " job %s." (You don't need the `the' here.)
-
apps/jobbrowser/src/jobbrowser/views.py (Diff revision 2) Would make get_matching_jobs() understand and check job visibility, rather than fixing the caller here. Probably don't need `user_exact'.
Description: |
|
|||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+74 -3) |
-
Looks good. Thanks!
-
apps/jobbrowser/src/jobbrowser/views.py (Diff revision 4) if not check_permission or request.user.is_superuser or j.profile.user == request.user)
Testing Done: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+74 -3) |