HUE-627 Spawning server pegs CPU at 100%

Review Request #2046 — Created April 27, 2012 and submitted

romain
old-hue-rw
HUE-627
hue
bcwalrus
commit dcf2c8903602abba1f35f549d8506cc3704209dc
Author: Romain Rigaux <romain@cloudera.com>
Date:   Fri Apr 27 16:14:39 2012 -0700

    HUE-627 Spawning server pegs CPU at 100%
    
    Patching evenlet 0.9.14

:100644 100644 096f1d0... 69872ae... M	desktop/core/ext-py/eventlet-0.9.14/eventlet/hubs/poll.py
Various load testing, could not reproduce it
Unit tests
The shells and the other apps seem working normally

Eventlet seemed to be the culprit and was not removing the file descriptor with these errors:

POLLERR 	Error condition of some sort
POLLHUP 	Hung up


Should we: 
  - just patch our eventlet?
  - try to push it upstream and upgrade our eventlet?
  - do both


bcwalrus
  1. Excellent work!
    
    Eventlet is now at 0.9.15. Let's see what they've fixed and whether we should upgrade. If this remove fd thing is not in 0.9.15, we should also submit your fix to Eventlet.
    1. Another thought: Are we not handling connection close properly? Normally, POLLERR and POLLHUP are rare, no? (I hope it's not POLLERR. You get POLLHUP if you're not closing when you're supposed to.)
  2. 
      
philip
  1. Good find!
    
  2. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...