[jobsub] HTTP 500 trying to install Job Design samples

Review Request #2058 — Created May 1, 2012 and submitted

romain
old-hue-rw
hue
bcwalrus
commit 6d542ed4cd8a47ed82c019a7f601b748231591d2
Author: Romain Rigaux <romain@cloudera.com>
Date:   Tue May 1 12:34:46 2012 -0700

    [jobsub] HTTP 500 trying to install Job Design samples
    
    Try to create the home dir of the default hue user (where
    the samples are saved)
    Replace 500 error by an error message

:100644 100644 0200dbc... d177dda... M  apps/jobsub/src/jobsub/management/commands/jobsub_setup.py
:100644 100644 3d0cec2... 1d84318... M  apps/jobsub/src/jobsub/views.py
:100644 100644 e305dde... e353c01... M  desktop/libs/hadoop/src/hadoop/fs/webhdfs.py
Ran tests (but most of the jobsub tests are disabled...)
Manual testing done

We only try to create the home dir of the default user.
This is directly done in the install sample command.
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
bcwalrus
  1. Thanks!
  2. apps/jobsub/src/jobsub/management/commands/jobsub_setup.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    This part could probably move to webhdfs.py. It'll be useful when useradmin adds a "create home" button.
  3. 
      
romain
bcwalrus
  1. 
      
  2. Technically speaking, there is this:
    http://hadoop.apache.org/common/docs/r1.0.0/webhdfs.html#GETHOMEDIRECTORY
    
    I'd suggest adding an optional `home_path' param. If it's not specified, we get the home directory using the REST api call. Jobsub will fully specify '/user/hue' in this case.
  3. 
      
romain
romain
bcwalrus
  1. 
      
  2. Should be 0755.
    1. Fixed
      
      Thanks for the review!
  3. 
      
romain
  1. 
      
  2. Changed to 
    
    assert_true(fs.isdir("/user/test"))
  3. 
      
romain
romain
romain
bcwalrus
  1. Ship It!
  2. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...