HUE-716 [jobsub] A normal user can't run his own designs

Review Request #2060 — Created May 3, 2012 and submitted

romain
old-hue-rw
HUE-716
hue
bcwalrus
commit f1713360fb5b750a0fe6edf47335af722a86e1c0
Author: Romain Rigaux <romain@cloudera.com>
Date:   Thu May 3 09:31:16 2012 -0700

    HUE-716 [jobsub] A normal user can't run his own designs
    
    The owner can submit/delete/edit his own designs.
    The admin can delete/edit any design.
    
    The jobsub data dir could be created in two ways:
      - installing the samples
      - submitting a design
    which were not following the same conventions. This is refactored
    and a test was added.

:100644 100644 a125670... e85aa48... M  apps/jobsub/src/jobsub/management/commands/jobsub_setup.py
:100644 100644 72e15b0... 1ac84ef... M  apps/jobsub/src/jobsub/submit.py
:100644 100644 010c00a... 0340ddf... M  apps/jobsub/src/jobsub/templates/list_designs.mako
:100644 100644 6064bfe... 5bc0515... M  apps/jobsub/src/jobsub/tests.py
:100644 100644 1d84318... 69adf9a... M  apps/jobsub/src/jobsub/views.py
Manual testing logged-in as an admin or a normal user.
Created a data dir from scratch by installing the samples then cloning and submitting a design.
Ran unit tests.

The main problem was a template problem but the goal of this patch is to fix once for all the jobsub data dir setup.
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
bcwalrus
  1. 
      
  2. apps/jobsub/src/jobsub/submit.py (Diff revision 1)
     
     
    Who is the owner of this new directory? Could you make sure that it's `hue'? It shouldn't be owned by the first user who submits a workflow.
    1. I see, I am adding a try/finally with Hdfs.DEFAULT_USER as the fs user inside.
  3. Only the user should be able to edit a workflow. The superuser can delete it, but shouldn't be able to muck with it.
    1. Ok, I made it like that.
  4. 
      
romain
bcwalrus
  1. Ship It!
  2. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...