HUE-671 [beeswax] Re-enable beeswax unit tests

Review Request #2073 — Created May 9, 2012 and submitted

romain
old-hue-rw
HUE-671
hue
bcwalrus
commit da08dfd0c6230c8f578eacdcd66eab7d6cb8f0f0
Author: Romain Rigaux <romain@cloudera.com>
Date:   Wed May 9 23:14:01 2012 -0700

    HUE-671 [beeswax] Re-enable beeswax unit tests
    
    Re-enable beeswax tests
    Fix beeswax tests
    Port SharedBeeswaxServer to work with pseudo_hdfs4 cluster
    Improve error message when installing beeswax samples twice
    Do not show 'Install samples' link if already installed

:100644 100644 eac4fda... cd5a8b3... M	apps/beeswax/src/beeswax/templates/index.mako
:100644 100644 9338ecc... 3692cce... M	apps/beeswax/src/beeswax/templates/show_tables.mako
:100644 100644 d82a37c... 4dfe740... M	apps/beeswax/src/beeswax/test_base.py
:100644 100644 c04b0b1... a92b599... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 a9f4678... 86138b2... M	apps/beeswax/src/beeswax/views.py
:100644 100644 cae3013... 8d6b831... M	desktop/libs/hadoop/src/hadoop/pseudo_hdfs4.py
All tests passing.
  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
bcwalrus
  1. Very nice. Thank you!
  2. apps/beeswax/src/beeswax/test_base.py (Diff revision 1)
     
     
    Would rename this as _SHARED_BEESWAX_SERVER_CLOSER.
  3. apps/beeswax/src/beeswax/test_base.py (Diff revision 1)
     
     
     
     
     
     
    Would remove unused items.
    
    Would add a comment on HIVE_CONF_DIR. We do this to avoid picking up a hive-site.xml from the development environment.
    1. I removed the un-used items and the hardcoded HIVE_HOME.
  4. apps/beeswax/src/beeswax/test_base.py (Diff revision 1)
     
     
     
    Remove?
    1. I put it back, I forgot to clean these variables.
  5. This is a bit misleading. Would rename "env" -> "_mr1_env". You can make an accessor for that separately.
    1. Yes, "env" is too generic indeed. I added a mr1_env property.
  6. 
      
romain
bcwalrus
  1. Ship It!
  2. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...