[beeswax] Save table as a file opens output directory

Review Request #2080 — Created May 15, 2012 and submitted

romain
old-hue-rw
hue
bcwalrus
commit 07e14882e15584480c65ae5bd9cc794ae8ff40ac
Author: Romain Rigaux <romain@cloudera.com>
Date:   Tue May 15 14:17:28 2012 -0700

    [beeswax] Save table as a file opens output directory
    
    Open Filebrowser page on the output directory.
    Removed deprecated PopupWithJframe.

:100644 100644 d927866... 425819e... M  apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 cd5a8b3... dab5123... M  apps/beeswax/src/beeswax/templates/index.mako
:100644 100644 ad18e9a... 4952947... M  apps/beeswax/src/beeswax/templates/save_results.mako
:100644 100644 34bb1f4... 8dd057f... M  apps/beeswax/src/beeswax/templates/watch_results.mako
:100644 100644 bc8f28d... 6b5333f... M  apps/beeswax/src/beeswax/tests.py
:100644 100644 1bca556... f32b03d... M  apps/beeswax/src/beeswax/views.py
:100644 100644 aa7a0b0... e5717b0... M  desktop/core/src/desktop/lib/django_util.py
:100644 000000 a2e2d71... 0000000... D  desktop/core/src/desktop/templates/popup_with_jframe.mako
Manual testing
Unit tests ran
grep-ed for popup_with_jframe.mako

As we are already in a popup we would need to refactor more if we want a confirmation message, right now we just open the FileBrowser on the directory (it is possible to go back easily as it is not a HTTP redirect).
bcwalrus
  1. 
      
  2. apps/beeswax/src/beeswax/views.py (Diff revision 1)
     
     
    Nit: We probably don't need to do format_preserving_redirect() any more. We can simply use the plain redirect.
    1. I put a HttpResponse, that way the user can still go back.
  3. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...