[shell] Can copy/paste shell output

Review Request #2083 — Created May 16, 2012 and submitted May 17, 2012, 4:49 a.m.

Information
Owner:	romain
Repository:	old-hue-rw
Branch:
Bugs:
Depends On:
Reviewers
Groups:	hue
People:	bcwalrus

Description

commit 3c7101184c4c80ba3ab44dc4127918912746171d
Author: Romain Rigaux <romain@cloudera.com>
Date:   Wed May 16 14:13:30 2012 -0700

    [shell] Can copy/paste shell output
    
    Fix copy/paste of shell output
    Fix prompt focus
    Remove extra \n in shell output

:100644 100644 78853b2... 0ef9dc9... M	apps/shell/src/shell/templates/index.mako
:100644 100644 7be6334... a0ba6c3... M	apps/shell/src/shell/tests.py

Testing Done

Manual testing in Chrome/FF.
Unit tests.

Ship it!

apps/shell/src/shell/templates/index.mako (Diff revision 1)

Seems simpler to just do:
    return text.replace(/&/g, '&')
               .replace(/</g, '<')
               ...

(I'm not suggesting that we improve the speed of this. We'll need a string builder, which is a hassle.)

romain May 17, 2012, 4:47 a.m.

Ok, it might recompile each regexp for each line of shell output but in practice it should not matter.

I can't upload a new diff for some reason but I basically did what you said.

You have a pending review.

Review Board 3.0.18

[shell] Can copy/paste shell output

Status: Closed (submitted)