[core] Thrift calls can hang forever in the unit tests

Review Request #2094 — Created May 18, 2012 and submitted

romain
old-hue-rw
hue
bcwalrus
commit 5969c676fde97b652bab03e6b52ccfdb62f644a6
Author: Romain Rigaux <romain@cloudera.com>
Date:   Fri May 18 18:01:25 2012 -0700

    [core] Thrift calls can hang forever in the unit tests

:100644 100644 edbf968... ffc854f... M  apps/beeswax/src/beeswax/test_base.py
:100644 100644 c15ab4d... 5e1c4cf... M  desktop/core/src/desktop/lib/thrift_util_test.py
Because of "[core] Spawning server should not be blocked by network calls" (https://github.com/cloudera/hue/commit/5c5141ecbb0f5dbed298286215ae454918be3049)
tests were hanging with:
[18/May/2012 18:09:10 +0000] thrift_util_test INFO     Waiting for service to come online
(stuck self.greenlet.switch())


Tests are now passing.
   - Checking for SimpleThriftServer startup was failing, added a timeout.
   - Skip a ping test.
   - Checking for Beeswax startup was hanging too.

Still need to investigate more.
  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
This might be too aggressive. Could happen on a really busy jenkins slave. Perhaps set it to 5? bcwalrus bcwalrus
bcwalrus
  1. Unit tests don't run eventlet loop. So is it unsafe to patch the modules when we're not using the spawning server?
    1. They are working fine when I checked manually with cherrypy. It might be a test problem.
  2. This might be too aggressive. Could happen on a really busy jenkins slave. Perhaps set it to 5?
    1. It is going to retry for 60s but yes I can put 5s.
  3. 
      
bcwalrus
  1. Ship It!
  2. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...