[oozie] New oozie front end

Review Request #2417 - Created Nov. 1, 2012 and submitted

Abraham Elmahrek
old-hue-rw
HUE-888
hue
enricoberti, romain
commit 77aa9c0cd82abbc98c2bd32446786d0b457ef7bf
Author: abec <abe@cloudera.com>
Date:   Wed Sep 12 10:53:38 2012 -0700

    [oozie] New oozie front end
    
    - Added managers for managing lists.
    - Models for links, nodes, workflows.
    - Grab workflow in a full dump from API when read.
    - Send full dump of workflow to API when update.
    - Models for nodes, workflows.
    - Grab workflow in a full dump from API when read.
    - Send full dump of workflow to API when update.
    - Added models and model choosers
    - Selected method of extension
    - Selected method of mapping to models
    - mapping ko module used to map JSON to a view model
    - workflow editable on front end
    - import not doable front end only
    - remove import action
    - Workflow edition and addition in front end
    - Add drag n drop padding
    - Forking is more stable
    - Can drag and drop nodes onto links beneath forks and prepend to child list
    - Added decision node
    - Fixed a few test cases
    - Skipping all action tests for editor
    - Added test cases for saving workflow and fetching workflow data
    - Fixed a few UI bugs

:100755 100755 1b070b9... afc43c3... M  apps/beeswax/beeswax_server.sh
:000000 100644 0000000... 1db4781... A  apps/oozie/src/oozie/migrations/0009_auto__add_decision.py
:100644 100644 82bd210... b3541e0... M  apps/oozie/src/oozie/models.py
:000000 100644 0000000... fd01b64... A  apps/oozie/src/oozie/templates/editor/action_utils.mako
:000000 100644 0000000... 6f17dd4... A  apps/oozie/src/oozie/templates/editor/control_utils.mako
:100644 100644 9954791... bf003ea... M  apps/oozie/src/oozie/templates/editor/edit_workflow.mako
:100644 100644 00f084f... 122279d... M  apps/oozie/src/oozie/templates/editor/edit_workflow_action.mako
:000000 100644 0000000... de2f75f... A  apps/oozie/src/oozie/templates/editor/workflow_utils.mako
:100644 100644 e9cbe29... 663c9ee... M  apps/oozie/src/oozie/templates/utils.inc.mako
:100644 100644 298a012... 5553783... M  apps/oozie/src/oozie/tests.py
:100644 100644 f1bce50... 97b0d89... M  apps/oozie/src/oozie/urls.py
:000000 100644 0000000... 8be52c5... A  apps/oozie/src/oozie/views/api.py
:100644 100644 e6b70cc... 34318b6... M  apps/oozie/src/oozie/views/editor.py
:000000 100755 0000000... 52f01c5... A  desktop/core/static/ext/js/jquery/plugins/jquery-ui-autocomplete-1.9.1.min.js
:000000 100755 0000000... 4c55f17... A  desktop/core/static/ext/js/jquery/plugins/jquery-ui-draggable-droppable-sortable-1.8.23.min.js
:000000 100644 0000000... c1cc16d... A  desktop/core/static/ext/js/knockout.mapping-2.3.2.js
:100644 100644 da6b2eb... 15ed055... M  desktop/libs/liboozie/src/liboozie/oozie_api.py
:100644 100644 f4d4aae... 647d5b1... M  desktop/libs/liboozie/src/liboozie/submittion.py
:100644 100644 9666c07... 843434a... M  desktop/libs/liboozie/src/liboozie/types.py
Unit tests
Visual confirmation
  • 1
  • 0
  • 23
  • 2
  • 26
Description From Last Updated
No 'import *' Romain Rigaux
  1. Quick first pass on the views/models, I need to dig a bit more for the js but it is promising.
  2. apps/beeswax/beeswax_server.sh (Diff revision 1)
     
     
    To remove
  3. Will have to check for the South bug
  4. apps/oozie/src/oozie/models.py (Diff revision 1)
     
     
    'has_default' not used
  5. Comments here and below
    
  6. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
    This test should also fetch the object in the DB, compare the fields...etc
    1. Added a few property checks.
  7. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
    I would rather just have 'save' tested because it is brittle otherwise
  8. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
     
     
    This should be kept, sharing a workflow is more than just changing its shared attributed if I remember correctly
    1. I've added more logic around sharing.
  9. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
    and it broke the test
  10. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
    Need a perm test for saving a workflow
  11. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
    Will need perms tests of the API
    1. Really only need to test save workflow
  12. apps/oozie/src/oozie/tests.py (Diff revision 1)
     
     
     
     
     
     
     
    Save comment a before
  13. apps/oozie/src/oozie/views/editor.py (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Should be in models.py
  14. 
      
  1. Just tiny things, looks really nice overall I think.
    
    Let me test a bit the app for bugs but I guess we are very close to v1.
  2. apps/oozie/src/oozie/models.py (Diff revisions 1 - 2)
     
     
    exception_class?
  3. just do a seach/replace of ' +$'
  4. apps/oozie/src/oozie/tests.py (Diff revisions 1 - 2)
     
     
    delete?
  5. apps/oozie/src/oozie/tests.py (Diff revisions 1 - 2)
     
     
    for index, node in enumerate(node_list): ?
  6. apps/oozie/src/oozie/tests.py (Diff revisions 1 - 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    duplication with previous one, should be moved to a function?
  7. apps/oozie/src/oozie/tests.py (Diff revisions 1 - 2)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
  8. apps/oozie/src/oozie/tests.py (Diff revisions 1 - 2)
     
     
  9. apps/oozie/src/oozie/urls.py (Diff revisions 1 - 2)
     
     
    remove?
  10. apps/oozie/src/oozie/urls.py (Diff revisions 1 - 2)
     
     
    about 'import_action', probably we could see the JobSub actions when we are done with HUE-896 I guess
  11. 
      
  1. 
      
    1. Need this to distinguish between 'default' and 'related'
  2. apps/oozie/src/oozie/tests.py (Diff revisions 2 - 4)
     
     
    No 'import *'
  3. 
      
Review request changed

Status: Closed (submitted)

Loading...