HUE-913 [core] Convert new jump to column to jQuery plugin and test it

Review Request #2435 - Created Nov. 12, 2012 and submitted

Enrico Berti
abec, romain
commit 58974f86b9be74c6aca9ce627c0e535826a3e509
Author: Enrico Berti <>
Date:   Mon Nov 12 17:23:54 2012 +0100

    HUE-913 [core] Convert new jump to column to jQuery plugin and test it
    Refactored HUE-899 to jQuery plugin
    Added plugin to the 'sample' tab of a table
    Added basic infrastructure for jQuery plugins Jasmine tests
    Improved usability of the plugin (fixed headers, toggable tooltip with row identifier)

:100644 100644 d8cc8b4... 870183b... M	apps/beeswax/src/beeswax/templates/describe_table.mako
:100644 100644 7b28e74... e559ae4... M	apps/beeswax/src/beeswax/templates/watch_results.mako
:100644 100644 970f201... f58b07e... M	desktop/core/src/desktop/templates/common_header.mako
:000000 100644 0000000... ab57a17... A	desktop/core/src/desktop/templates/jasmine.mako
:100644 100644 7aadaca... 8828f11... M	desktop/core/src/desktop/
:100644 100644 31d42e0... f3d6e01... M	desktop/core/src/desktop/
:100644 100644 fb45e94... 9e5e891... M	desktop/core/static/css/hue2.css
:000000 100644 0000000... bf43c6f... A	desktop/core/static/jasmine/jHueSelectorFixture.html
:000000 100644 0000000... 8c44753... A	desktop/core/static/jasmine/jHueSelectorSpec.js
:000000 100644 0000000... 5e415ce... A	desktop/core/static/jasmine/jHueTableExtenderFixture.html
:000000 100644 0000000... 2ce26dc... A	desktop/core/static/jasmine/jHueTableExtenderSpec.js
:000000 100644 0000000... 0013669... A	desktop/core/static/js/Source/jHue/jquery.tableextender.js
Manual FF + Chrome
Basic jasmine test to see that the plugin is applied to the element. We need a better framework for visual testing imho.
  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
  1. Looks good to me!
    Will see for adding the js tests to the build this week.
  2. Gone with jHueTableExtenderNavigator I guess. Can't describe_table.mako do the same? 
    1. I refactored it and moved to a css class, it saves ~1MB of generated code on huge tables!
      And it's already on the describe_table page as well.
  3. Testing for the scroll requires the DOM?
    1. Yep, we need to convert the table to a datatable, apply our plugin and then check for the scroll
Review request changed

Status: Closed (submitted)