ACCESS-2: Initial import of authz side work

Review Request #2731 — Created March 7, 2013 and submitted

brock
old-access
master
ACCESS-2
jarcec, prasadm, shreepadma
Initial import of private branch.


jarcec
  1. Hi Brock,
    thank you very much for putting this together. I do have couple of high level notes:
    
    1) Would it be possible to cut the code and put generic pieces into "core" module?
    
    2) Would it be possible to change the namespace to com.cloudera.access instead of com.cloudera.hive?
    
    3) Nit: Would you mind removing the trailing white space characters?
    
    Jarcec
    1. 1) I was planning on doing a followup JIRA to move things around into the correct places.  Sound good?
      
      2) Will do
      
      3) Will do
    2. 1) Reason being I am still thinking about what goes where.
  2. access-provider/access-provider-file/pom.xml (Diff revision 1)
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
     
    Thank you for fixing missing Apache license, appreciated.
  3. Jarcec
brock
brock
brock
brock
brock
brock
prasadm
  1. Hey Brock,
    
       Looks good!
    I do agree with Jarcec on the interface being bit too specific to Hive. The AuthrizationProvider interface would need to accommodate various combinations of object types. May be it can accept an interface for the object type instead of various overloaded authorize methods.
    
    thanks
    Prasad
    1. Hi guys,
      
      The scope of this JIRA isn't the final interface, it's just an initial commit so we can have something to iterate on in later JIRAs.  Beyond that this patch is already 40KB so I propose we don't make it an uber jira. To that end I have created https://issues.cloudera.org/browse/ACCESS-3 to define the AuthProvider interface. Should we take the AuthProvider interface discussion over there?
      
      Brock
  2. 
      
prasadm
  1. Ship It!
  2. 
      
brock
Review request changed

Status: Closed (submitted)

jarcec
  1. Ship it! Sorry for my late response.
    
    Jarcec
  2. 
      
shreepadma
  1. Brock-I've not had a chance to look closely at the policy file format, but I guess we can look at it and file follow on JIRA if needed.
    1. Shreepadma, it'd be great to have you checkout the format to make sure it will be flexible enough to fit our needs. I have crated https://issues.cloudera.org/browse/ACCESS-4 for this task. Thanks!
  2. 
      
Loading...