HUE-1111 [beeswax] Save and edit the description of a query

Review Request #2815 — Created April 1, 2013 and submitted

romain
old-hue-rw
HUE-1111
hue
abec, enricoberti
commit 2a5769cb7bf0a27dfac552355512de7bc22a1b6f
Author: Romain Rigaux <romain@cloudera.com>
Date:   Wed Mar 20 14:55:34 2013 -0700

    HUE-1111 [beeswax] Save and edit the description of a query
    
    Introducing X-editable
    Ajax edition of Name and Description
    Checks for empty name
    Add tests

:100644 100644 beac885... cb394f2... M	NOTICE.txt
:100644 100644 398e7d0... 76912ea... M	apps/beeswax/src/beeswax/forms.py
:100644 100644 539e0c5... 73afc75... M	apps/beeswax/src/beeswax/templates/execute.mako
:100644 100644 347f5b2... 26d0801... M	apps/beeswax/src/beeswax/templates/my_queries.mako
:100644 100644 2255eeb... fca008f... M	apps/beeswax/src/beeswax/tests.py
:100644 100644 6f9b218... 7af75eb... M	apps/beeswax/src/beeswax/urls.py
:100644 100644 35377e4... 95ac8a5... M	apps/beeswax/src/beeswax/views.py
:000000 100644 0000000... 97c2bd3... A	desktop/core/static/ext/css/bootstrap-editable.css
:000000 100644 0000000... 73e035c... A	desktop/core/static/ext/js/bootstrap-editable.min.js
manual + tests

Sometimes it seems that only clicking on the upper part of the ok button works? This is annoying as we lose the edit...
  • 1
  • 0
  • 3
  • 0
  • 4
Description From Last Updated
double quotes enricoberti enricoberti
enricoberti
  1. Nice! It doesn't break for me and I tested it on Safari, Chrome, Firefox and IE8!
    1. Great!
      I did the changes!
  2. <div style="margin-bottom: 30px"> is probably better
  3. Remove icon, it looks better without and the underline/highlight of the name and description give enough invitation to the user :)
  4. </div> goes with the change on line 255
  5. 
      
romain
Review request changed

Status: Closed (submitted)

Loading...