HUE-1327 [search] disallow changing of collection index to non-existing index

Review Request #3193 — Created June 18, 2013 and submitted

abec
old-hue-rw
HUE-1327
hue
enricoberti, kevin.wang, romain
commit 9a3a402db3815e92818ed0ae5b7e9b4fb46cdbb9
Author: Abraham Elmahrek <abraham@elmahrek.com>
Date:   Tue Jun 18 18:45:46 2013 -0700

    HUE-1327 [search] disallow changing of collection index to non-existing index
    
    - Validate collection or core
    - Change collection type to core or collection based on
      whether collection or core is provided

:100644 100644 d59c811... bc003d0... M	apps/search/src/search/forms.py
:100644 100644 3c36d0b... 99b7682... M	apps/search/src/search/search_controller.py
:100644 100644 e0dcf96... fbd57f1... M	apps/search/src/search/views.py
Manually tested incorrect collection name.
Manually tested core name provided when is collection.
Manually tested collection name provided when is core.
  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
same romain romain
enricoberti
  1. UX FTW! :)
  2. 
      
romain
  1. Great!!
  2. apps/search/src/search/forms.py (Diff revision 1)
     
     
    "No live Solr ...." ?
  3. In practice I found it simpler to be more specific about the args:
    
     collection -->  collection_name
    
    as sometimes is it collection_id, collection object...
  4. 
      
abec
Review request changed

Status: Closed (submitted)

Loading...